Merge branch 'main' into feat/ui5-test-writer/ui-hidden-for-sections

Author: sap-sebelao

.changeset/op-title-icheck-title-path.md

@@ -0,0 +1,5 @@
+---
+"@sap-ux/ui5-test-writer": minor
+---
+
+FEAT: Generate Object Page header title check using iCheckTitlePath (binding-path based)

packages/ui5-test-writer/src/utils/modelUtils.ts

@@ -56,6 +56,13 @@ export interface HeaderSectionItem extends SectionItem {
     };
 }
 
+export interface HeaderItem extends TreeAggregation {
+    properties?: {
+        title?: { value?: string };
+        description?: { value?: string };
+    };
+}
+
 export interface PageWithModelV4WithProperties extends PageWithModelV4 {
     routePattern?: string;
 }

packages/ui5-test-writer/src/utils/objectPageUtils.ts

@@ -17,6 +17,7 @@ import {
     type AggregationItem,
     type BodySectionItem,
     type FieldItem,
+    type HeaderItem,
     type HeaderSectionItem,
     type SectionItem,
     getAggregations,
@@ -70,6 +71,8 @@ export async function getObjectPageFeatures(
             listReportPageKey,
             parentLRTableIdentifier
         );
+        // extract header title binding path (for iCheckTitlePath)
+        pageFeatureData.headerTitle = getHeaderTitlePath(objectPage);
         // extract header sections (facets)
         pageFeatureData.headerSections = extractObjectPageHeaderSectionsData(objectPage);
         // extract body sections (includes section-level actions and standard create/delete buttons)
@@ -158,6 +161,25 @@ function getObjectPageNavigationParents(
     };
 }
 
+/**
+ * Returns the OData property path the Object Page header title is bound to, for use with
+ * `iCheckTitlePath`. Returns undefined for static titles that expose no binding path.
+ *
+ * @param objectPage - object page from the application model
+ * @returns the title binding path, or undefined
+ */
+function getHeaderTitlePath(objectPage: PageWithModelV4): string | undefined {
+    if (!objectPage.model) {
+        return undefined;
+    }
+    const header = getAggregations(objectPage.model.root)['header'] as HeaderItem | undefined;
+    const titlePath = header?.properties?.title?.value;
+    if (!titlePath) {
+        return undefined;
+    }
+    return titlePath;
+}
+
 /**
  *  Extracts header sections data from an object page model.
  *

packages/ui5-test-writer/templates/v4/1.150/integration/ObjectPageJourney.js

@@ -61,6 +61,12 @@ sap.ui.define([
         });
 <% } -%>
 
+<% if (headerTitle) { -%>
+        opaTest("Check header title of the Object Page", function (_Given, _When, Then) {
+            Then.onThe<%- name%>Generated.onHeader().iCheckTitlePath(<%- JSON.stringify(headerTitle) %>);
+        });
+
+<% } -%>
 <% if (headerSections?.length > 0) { -%>
         opaTest("Check header facets of the Object Page", function (Given, When, Then) {
 <% headerSections.forEach(function(section) { -%>

packages/ui5-test-writer/templates/v4/1.150/integration/ObjectPageJourney.ts

@@ -83,6 +83,12 @@ function journey() {
     });
 <% } -%>
 
+<% if (headerTitle) { -%>
+    opaTest("Check header title of the Object Page", function (_Given: Given, _When: When, Then: Then) {
+        Then.onThe<%- name%>Generated.onHeader().iCheckTitlePath(<%- JSON.stringify(headerTitle) %>);
+    });
+
+<% } -%>
 <% if (headerSections?.length > 0) { -%>
     opaTest("Check header facets of the Object Page", function (_Given: Given, _When: When, Then: Then) {
 <% headerSections.forEach(function(section) { -%>

packages/ui5-test-writer/templates/v4/1.84/integration/ObjectPageJourney.js

@@ -61,6 +61,12 @@ sap.ui.define([
         });
 <% } -%>
 
+<% if (headerTitle) { -%>
+        opaTest("Check header title of the Object Page", function (_Given, _When, Then) {
+            Then.onThe<%- name%>Generated.onHeader().iCheckTitlePath(<%- JSON.stringify(headerTitle) %>);
+        });
+
+<% } -%>
 <% if (headerSections?.length > 0) { -%>
         opaTest("Check header facets of the Object Page", function (Given, When, Then) {
 <% headerSections.forEach(function(section) { -%>

packages/ui5-test-writer/templates/v4/1.84/integration/ObjectPageJourney.ts

@@ -80,6 +80,12 @@ function journey() {
     });
 <% } -%>
 
+<% if (headerTitle) { -%>
+    opaTest("Check header title of the Object Page", function (_Given: Given, _When: When, Then: Then) {
+        Then.onThe<%- name%>Generated.onHeader().iCheckTitlePath(<%- JSON.stringify(headerTitle) %>);
+    });
+
+<% } -%>
 <% if (headerSections?.length > 0) { -%>
     opaTest("Check header facets of the Object Page", function (_Given: Given, _When: When, Then: Then) {
 <% headerSections.forEach(function(section) { -%>

packages/ui5-test-writer/test/test-input/constants.ts

@@ -805,6 +805,10 @@ export type Then = Opa5 & BaseArrangements & {
 
             const bookingObjPageJourneyContent =
                 fs.dump()['test/test-output/LROPv4/webapp/test/integration/BookingObjectPageJourney.gen.js'].contents;
+            expect(bookingObjPageJourneyContent).toContain('onHeader().iCheckTitlePath("BookingID")');
+            const travelObjPageJourneyContent =
+                fs.dump()['test/test-output/LROPv4/webapp/test/integration/TravelObjectPageJourney.gen.js'].contents;
+            expect(travelObjPageJourneyContent).toContain('onHeader().iCheckTitlePath("TravelID")');
             expect(bookingObjPageJourneyContent).toContain('iCheckHeaderFacet({ facetId: "DataPoint::FlightDate" }');
             expect(bookingObjPageJourneyContent).toContain('iCheckHeaderFacet({ facetId: "DataPoint::BookingDate" }');
             expect(bookingObjPageJourneyContent).toContain('iCheckHeaderFacet({ facetId: "FieldGroup::Names" }');

packages/ui5-test-writer/test/unit/fiori-elements.test.ts

@@ -340,6 +340,52 @@ describe('Test getObjectPageFeatures()', () => {
         expect(result[0].headerSections?.[0].stashed).toBe(false);
     });
 
+    test('should extract header title binding path from header.properties.title.value', async () => {
+        const objectPage = {
+            name: 'objectPage1',
+            pageType: 'ObjectPage',
+            model: {
+                root: {
+                    aggregations: {
+                        header: {
+                            properties: {
+                                title: { value: 'Customer' }
+                            },
+                            aggregations: {}
+                        } as unknown as TreeAggregation
+                    }
+                } as unknown as TreeAggregation,
+                name: 'test',
+                schema: {}
+            }
+        };
+        const result = await getObjectPageFeatures([objectPage] as PageWithModelV4[], 'listReportPage', mockLogger);
+        expect(result).toHaveLength(1);
+        expect(result[0].headerTitle).toBe('Customer');
+    });
+
+    test('should leave headerTitle undefined when no title binding path is present', async () => {
+        const objectPage = {
+            name: 'objectPage1',
+            pageType: 'ObjectPage',
+            model: {
+                root: {
+                    aggregations: {
+                        header: {
+                            properties: { title: { value: '' } },
+                            aggregations: {}
+                        } as unknown as TreeAggregation
+                    }
+                } as unknown as TreeAggregation,
+                name: 'test',
+                schema: {}
+            }
+        };
+        const result = await getObjectPageFeatures([objectPage] as PageWithModelV4[], 'listReportPage', mockLogger);
+        expect(result).toHaveLength(1);
+        expect(result[0].headerTitle).toBeUndefined();
+    });
+
     test('should extract header sections with facetId containing # replaced with ::', async () => {
         const objectPage = {
             name: 'objectPage1',