fix(capi): reject null and atom objects in raw vector readers (#21)

Co-authored-by: Evgen Byelozorov <belowzeroff@gmail.com>

Author: belowzeroff

rayforce/capi/raypy_serde.c

@@ -49,7 +49,7 @@ PyObject *raypy_read_u8_vector(PyObject *self, PyObject *args) {
   if (!PyArg_ParseTuple(args, "O!", &RayObjectType, &obj))
     return NULL;
 
-  if (obj->obj->type != RAY_U8) {
+  if (obj->obj == NULL || obj->obj->type != RAY_U8 || !ray_is_vec(obj->obj)) {
     PyErr_SetString(PyExc_RuntimeError, "read: object is not a u8 vector");
     return NULL;
   }
@@ -65,6 +65,12 @@ PyObject *raypy_read_vector_raw(PyObject *self, PyObject *args) {
   if (!PyArg_ParseTuple(args, "O!", &RayObjectType, &obj))
     return NULL;
 
+  /* Atoms alias `len` with their payload, so only true vecs are readable. */
+  if (obj->obj == NULL || !ray_is_vec(obj->obj)) {
+    PyErr_SetString(PyExc_RuntimeError, "read_vector_raw: object is not a vector");
+    return NULL;
+  }
+
   size_t elem_size = ray_scalar_elem_size(obj->obj->type);
   if (elem_size == 0) {
     PyErr_SetString(PyExc_RuntimeError,

tests/ffi/test_init_read.py

@@ -370,3 +370,25 @@ def test_large_list_stress():
     # Spot-check first and last.
     assert FFI.read_i64(FFI.at_idx(lst, 0)) == 0
     assert FFI.read_i64(FFI.at_idx(lst, count - 1)) == count - 1
+
+
+def test_read_vector_raw_rejects_non_vectors():
+    """Regression: read_vector_raw / read_u8_vector used to dereference the
+    underlying pointer without checks, so a bare RayObject() (obj == NULL)
+    segfaulted the interpreter and an atom read garbage length bytes."""
+    with pytest.raises(RuntimeError, match="not a vector"):
+        r.read_vector_raw(r.RayObject())
+
+    with pytest.raises(RuntimeError, match="not a u8 vector"):
+        r.read_u8_vector(r.RayObject())
+
+    # Atoms alias `len` with their payload — must be rejected, not read.
+    with pytest.raises(RuntimeError, match="not a vector"):
+        r.read_vector_raw(FFI.init_i64(5))
+
+    with pytest.raises(RuntimeError, match="not a u8 vector"):
+        r.read_u8_vector(FFI.init_u8(5))
+
+    # Real vectors still read fine.
+    vec = FFI.init_vector(r.TYPE_I64, [1, 2, 3])
+    assert len(FFI.read_vector_raw(vec)) == 3 * 8