Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds Galaxy tool wrappers for converting and describing mass spectral libraries in the mzspeclib format.
- Introduces sample test data for MSP and mzspeclib text formats, plus an expected describe report.
- Provides
mzspeclib_convert.xmlandmzspeclib_describe.xmlwith commands, inputs, outputs, tests, and help. - Updates version macros (
macros.xml) and suite metadata (.shed.yml).
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/mzspeclib/test-data/sample_describe_report.txt | Sample output used in describe tool test |
| tools/mzspeclib/test-data/sample.txt | Sample mzspeclib text-format library |
| tools/mzspeclib/test-data/sample.msp | Sample MSP-format library |
| tools/mzspeclib/mzspeclib_describe.xml | Galaxy wrapper for mzspeclib describe |
| tools/mzspeclib/mzspeclib_convert.xml | Galaxy wrapper for mzspeclib convert |
| tools/mzspeclib/macros.xml | Defines @TOOL_VERSION@ and creator/citation macros |
| tools/mzspeclib/.shed.yml | Suite metadata for Galaxy Tool Shed |
Comments suppressed due to low confidence (3)
tools/mzspeclib/mzspeclib_describe.xml:14
- The
-iflag here appears to pass a prefixed filename (mzspeclib.${input.ext}) rather than the intended input format (e.g.,txtorjson). Consider changing to-i ${input.ext}so that the CLI correctly interprets the input format.
mzspeclib describe -i mzspeclib.${input.ext} ${input} > ${output}
tools/mzspeclib/mzspeclib_convert.xml:14
- The argument order may not align with
mzspeclib convertsyntax, which typically expects the input file immediately after the command. Verify the CLI usage and consider reordering tomzspeclib convert ${input} -i ${input.ext} -f text ${output}.
mzspeclib convert -i ${input.ext} -f text ${input} ${output}
tools/mzspeclib/.shed.yml:1
- [nitpick] For consistency with the official project branding (
mzSpecLib), consider updating occurrences ofmzspeclibin the suite metadata (e.g.,name,description) to use the canonical capitalization.
name: mzspeclib
Collaborator
|
@hechth looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tool wrappers to validate and convert libraries to mzspeclib format.
Closes #668
The mzSpecLib validate tool is postponed until HUPO-PSI/mzspeclib-py#5 is merged and we have a new release 1.0.7