Skip to content

Commit 246b4e4

Browse files
authored
Merge pull request #8197 from maiieul/fix-use-resource-onRejected-catching
fix: use-resource not catching onRejected
2 parents fe8566a + 7d62aa2 commit 246b4e4

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

.changeset/kind-yaks-rule.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@builder.io/qwik': patch
3+
---
4+
5+
fix: useResource's onRejected now catches errors again; preventing unhandled errors in test environments.

packages/qwik/src/core/use/use-resource.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -263,6 +263,7 @@ function getResourceValueAsPromise<T>(props: ResourceProps<T>): Promise<JSXOutpu
263263
const isBrowser = !isServerPlatform();
264264
if (isBrowser) {
265265
if (props.onRejected) {
266+
resource.value.catch(() => {});
266267
if (resource._state === 'rejected') {
267268
return Promise.resolve(resource._error!).then(useBindInvokeContext(props.onRejected));
268269
}

0 commit comments

Comments
 (0)