Unit Test Coverage

[paddatrapper]

Tests should cover the majority of the code base. Thus code coverage should be over 80%. Currently it is sitting at 25%

[nicce]

I'll happily take a look at this one. Not sure if a percentage limit is what to aim after. However I add test cases to where I see fit, and then you can tell me if you think I have missed something.

[paddatrapper]

Yeah, I agree with you. Thanks for looking into this!

[Ronan-H]

Should the classes in com.jadventure.game.menus be unit tested? I see there are currently no unit tests at all for those classes.

[paddatrapper]

Ideally yes, but I can't remember if there was an issue with it or if it just hasn't happened yet

[Ronan-H]

@paddatrapper Having a look right now. What would be the best way to test input/output to the menus? I see CommandCollectionTest uses System.setOut to test the output. Would it be OK to use System.setIn and System.setOut, and call QueueProvider.startMessenger(GameModeType.STAND_ALONE) to test the menus?

[paddatrapper]

@Ronan-H yeah that is probably the best way to do it. You may be able to tie into the QueueProvider, but it may well not be possible.

[Ronan-H]

Opened an issue about a rework idea for QueueProvider in #258 to make testing easier.