Update serializer.js to remove usage of lodash.get (#1390)

Author: rom1504

src/transforms/serializer.js

@@ -1,21 +1,18 @@
 'use strict'
 
-const ProtoDef = require('protodef').ProtoDef
-const Serializer = require('protodef').Serializer
-const Parser = require('protodef').FullPacketParser
+const { ProtoDef, Serializer, FullPacketParser } = require('protodef')
 const { ProtoDefCompiler } = require('protodef').Compiler
 
 const nbt = require('prismarine-nbt')
 const minecraft = require('../datatypes/minecraft')
 const states = require('../states')
 const merge = require('lodash.merge')
-const get = require('lodash.get')
 
 const minecraftData = require('minecraft-data')
 const protocols = {}
 
 function createProtocol (state, direction, version, customPackets, compiled = true) {
-  const key = state + ';' + direction + ';' + version + (compiled ? ';c' : '')
+  const key = `${state};${direction};${version}${compiled ? ';c' : ''}`
   if (protocols[key]) { return protocols[key] }
 
   const mcData = minecraftData(version)
@@ -27,10 +24,12 @@ function createProtocol (state, direction, version, customPackets, compiled = tr
     throw new Error(`Unsupported protocol version '${versionInfo.version}' (attempted to use '${mcData.version.version}' data); try updating your packages with 'npm update'`)
   }
 
+  const mergedProtocol = merge(mcData.protocol, customPackets?.[mcData.version.majorVersion] ?? {})
+
   if (compiled) {
     const compiler = new ProtoDefCompiler()
     compiler.addTypes(require('../datatypes/compiler-minecraft'))
-    compiler.addProtocol(merge(mcData.protocol, get(customPackets, [mcData.version.majorVersion])), [state, direction])
+    compiler.addProtocol(mergedProtocol, [state, direction])
     nbt.addTypesToCompiler('big', compiler)
     const proto = compiler.compileProtoDefSync()
     protocols[key] = proto
@@ -39,7 +38,7 @@ function createProtocol (state, direction, version, customPackets, compiled = tr
 
   const proto = new ProtoDef(false)
   proto.addTypes(minecraft)
-  proto.addProtocol(merge(mcData.protocol, get(customPackets, [mcData.version.majorVersion])), [state, direction])
+  proto.addProtocol(mergedProtocol, [state, direction])
   nbt.addTypesToInterperter('big', proto)
   protocols[key] = proto
   return proto
@@ -50,7 +49,7 @@ function createSerializer ({ state = states.HANDSHAKING, isServer = false, versi
 }
 
 function createDeserializer ({ state = states.HANDSHAKING, isServer = false, version, customPackets, compiled = true, noErrorLogging = false } = {}) {
-  return new Parser(createProtocol(state, isServer ? 'toServer' : 'toClient', version, customPackets, compiled), 'packet', noErrorLogging)
+  return new FullPacketParser(createProtocol(state, isServer ? 'toServer' : 'toClient', version, customPackets, compiled), 'packet', noErrorLogging)
 }
 
 module.exports = {