Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Commit 7737f44

Browse files
Merge pull request #183 from Pocket/renovate/opt-in-kotlin-test
chore(deps): move kotlin test to version catalog
2 parents 075791a + 12b0133 commit 7737f44

File tree

5 files changed

+8
-13
lines changed

5 files changed

+8
-13
lines changed

Pocket/build.gradle.kts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -313,15 +313,15 @@ dependencies {
313313

314314
testImplementation(Deps.Mockito.core)
315315
testImplementation(Deps.AssertJ.core)
316-
testImplementation(Deps.Jetbrains.Kotlin.jUnit)
316+
testImplementation(libs.kotlin.junit)
317317
testImplementation(Deps.MockK.mockk)
318318
testImplementation(platform(libs.kotlinx.coroutines.bom))
319319
testImplementation(libs.kotlinx.coroutines.test)
320-
testImplementation(Deps.Jetbrains.Kotlin.test)
320+
testImplementation(libs.kotlin.test)
321321
testImplementation(libs.turbine)
322322

323323
androidTestImplementation(Deps.AndroidX.Test.rules)
324-
androidTestImplementation(Deps.Jetbrains.Kotlin.jUnit)
324+
androidTestImplementation(libs.kotlin.junit)
325325
androidTestImplementation(platform(libs.androidx.compose.bom))
326326
androidTestImplementation(libs.androidx.compose.ui.test)
327327
debugImplementation(libs.androidx.compose.ui.test.manifest)

buildSrc/src/main/kotlin/Deps.kt

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,7 @@
33
*
44
* Deprecated: We're gradually migrating to version catalog
55
*/
6-
@Suppress("MemberNameEqualsClassName")
76
object Deps {
8-
object Jetbrains {
9-
object Kotlin {
10-
const val jUnit = "org.jetbrains.kotlin:kotlin-test-junit"
11-
const val test = "org.jetbrains.kotlin:kotlin-test-common"
12-
}
13-
}
147
object AndroidX {
158
object ViewPager2 {
169
private const val VERSION = "1.0.0"

gradle/libs.versions.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ dagger-hilt-compiler = { module = "com.google.dagger:hilt-compiler", version.ref
4444
firebase-bom = { module = "com.google.firebase:firebase-bom", version = "33.8.0" }
4545
firebase-messaging = { module = "com.google.firebase:firebase-messaging" }
4646
google-play-billing = { module = "com.android.billingclient:billing-ktx", version = "7.1.1" }
47+
kotlin-junit = { module = "org.jetbrains.kotlin:kotlin-test-junit" }
48+
kotlin-test = { module = "org.jetbrains.kotlin:kotlin-test-common" }
4749
kotlinx-coroutines-android = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-android" }
4850
kotlinx-coroutines-bom = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-bom", version = "1.10.1" }
4951
kotlinx-coroutines-core = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-core" }

sync-pocket-android/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,5 @@ dependencies {
2424
testImplementation(Deps.Mockito.core)
2525
testImplementation(libs.robolectric)
2626
testImplementation(Deps.Commons.IO.commonsIo)
27-
testImplementation(Deps.Jetbrains.Kotlin.jUnit)
27+
testImplementation(libs.kotlin.junit)
2828
}

sync-pocket/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ dependencies {
2828
implementation(libs.okhttp.urlconnection)
2929
implementation(libs.okio)
3030

31-
testImplementation(Deps.Jetbrains.Kotlin.test)
32-
testImplementation(Deps.Jetbrains.Kotlin.jUnit)
31+
testImplementation(libs.kotlin.test)
32+
testImplementation(libs.kotlin.junit)
3333
testImplementation(Deps.Mockito.Kotlin.mockitoKotlin)
3434
testImplementation(Deps.Commons.Codec.commonsCodec)
3535
testImplementation(libs.okhttp.mockwebserver)

0 commit comments

Comments
 (0)