Merge branch 'main' into 80-distribox-slave

Author: Laurent

backend/app/core/policies.py

@@ -81,6 +81,14 @@
         "policy": "vms:delete",
         "description": "Allows the user to remove virtual machines.",
     },
+    {
+        "policy": "vms:screenshot",
+        "description": "Allows the user to make virtual machine screenshots.",
+    },
+    {
+        "policy": "vms:duplicate",
+        "description": "Allows the user to duplicate a virtual machine.",
+    },
     {
         "policy": "vms:credentials:revoke",
         "description": "Allows the user to revoke virtual machine credentials.",

backend/app/core/xml_builder.py

@@ -1,6 +1,7 @@
 from lxml import etree
-from app.models.vm import VmRead
+from app.models.vm import VmCreateXML
 from app.core.constants import VMS_DIR
+from app.core.config import VIRT_TYPE
 
 LAYOUT_TO_KEYMAP = {
     "en-us-qwerty": "en-us",
@@ -31,8 +32,7 @@
 }
 
 
-def build_xml(vm_read: VmRead):
-    from app.core.config import VIRT_TYPE
+def build_xml(vm_read: VmCreateXML):
 
     domain = etree.Element("domain", type=VIRT_TYPE)
 

backend/app/models/vm.py

@@ -28,6 +28,10 @@ class VmCreate(VmBase):
     slave_id: Optional[UUID] = None
 
 
+class VmCreateXML(VmBase):
+    id: UUID
+
+
 class VmCredentialCreateRequest(BaseModel):
     name: str = Field(min_length=1)
     password: Optional[str] = None

backend/app/routes/vm.py

@@ -14,13 +14,13 @@
 router = APIRouter()
 
 
-@router.get(
-    "/{vm_id}/screenshot",
-    status_code=status.HTTP_200_OK,
-    responses={
-        200: {"content": {"image/jpeg": {}}, "description": "JPEG thumbnail of the VM screen"},
-    },
-)
+@router.get("/{vm_id}/screenshot",
+            status_code=status.HTTP_200_OK,
+            dependencies=[Depends(require_policy("vms:screenshot"))],
+            responses={200: {"content": {"image/jpeg": {}},
+                             "description": "JPEG thumbnail of the VM screen"},
+                       },
+            )
 async def get_vm_screenshot(vm_id: str, token: str = Query(...)):
     """Screenshot endpoint using query-param JWT auth (for <img src=> usage)."""
     payload = decode_access_token(token)
@@ -51,6 +51,17 @@ async def get_vm_screenshot(vm_id: str, token: str = Query(...)):
     )
 
 
+@router.post(
+    "/{vm_id}/duplicate",
+    status_code=status.HTTP_200_OK,
+    response_model=VmRead,
+    dependencies=[Depends(require_policy("vms:duplicate"))],
+    responses={403: {"model": MissingPoliciesResponse}},
+)
+def duplicate_vm(vm_id: str):
+    return VmService.duplicate_vm(vm_id)
+
+
 @router.delete(
     "/clean/{vm_id}",
     status_code=status.HTTP_204_NO_CONTENT,

backend/app/services/vm_service.py

@@ -6,7 +6,7 @@
 from app.utils.vm import wait_for_state
 from typing import Optional
 from app.core.constants import VMS_DIR, IMAGES_DIR, VM_STATE_NAMES
-from app.models.vm import VmCreate, VmRead, VmCredentialCreateRequest, RecoverableVm, RecoverableVmCreate
+from app.models.vm import VmCreate, VmRead, VmCredentialCreateRequest, RecoverableVm, RecoverableVmCreate, VmCreateXML
 from app.models.image import ImageRead
 from app.core.xml_builder import build_xml
 from app.core.config import QEMUConfig, engine
@@ -24,6 +24,7 @@
 from app.services.image_service import ImageService
 import yaml
 from pathlib import Path
+from sqlalchemy.orm import make_transient
 
 logger = logging.getLogger(__name__)
 
@@ -101,7 +102,14 @@ def __init__(self, vm_create: VmCreate):
                 ["qemu-img", "resize", vm_path, f"+{self.disk_size}G"],
                 check=True,
             )
-            vm_xml = build_xml(self)
+            vm_xml = build_xml(VmCreateXML(
+                id=self.id,
+                os=self.os,
+                name=self.name,
+                mem=self.mem,
+                vcpus=self.vcpus,
+                disk_size=self.disk_size
+            ))
             conn = QEMUConfig.get_connection()
             conn.defineXML(vm_xml)
             with Session(engine) as session:
@@ -292,6 +300,7 @@ def _get_vm_or_404(session: Session, vm_id: str) -> VmORM:
             )
         return vm_record
 
+
     @staticmethod
     def _get_slave_for_vm(vm_id: str) -> Optional[SlaveORM]:
         """Check if a VM is hosted on a slave node."""
@@ -301,6 +310,21 @@ def _get_slave_for_vm(vm_id: str) -> Optional[SlaveORM]:
                 return session.get(SlaveORM, vm_record.slave_id)
         return None
 
+
+    @staticmethod
+    def _get_duplicate_name(session: Session, vm_name: str) -> str:
+        base_name = f"Duplicate of {vm_name}"
+        search_pattern = f"{base_name}%"
+
+        statement = select(
+            func.count(
+                VmORM.id)).where(
+            VmORM.name.like(search_pattern))
+        count = session.exec(statement).one()
+        if count == 0:
+            return base_name
+        return f"{base_name}({count})"
+
     def get_vm_list():
         with Session(engine) as session:
             vm_records = session.scalars(select(VmORM)).all()
@@ -678,3 +702,35 @@ def remove_all_recoverable_vms():
                     rmtree(VMS_DIR / v.name)
                     break
         return
+
+    @staticmethod
+    def duplicate_vm(vm_id: str):
+        with Session(engine) as session:
+            vm_to_duplicate = VmService._get_vm_or_404(session, vm_id)
+            duplicate_vm = VmORM(**vm_to_duplicate.model_dump())
+            duplicate_vm.id = uuid.uuid4()
+            duplicate_vm.name = VmService._get_duplicate_name(
+                session, duplicate_vm.name)
+
+            src_path = VMS_DIR / vm_id / duplicate_vm.os
+            dest_path = VMS_DIR / str(duplicate_vm.id)
+
+            dest_path.mkdir(parents=True, exist_ok=True)
+            copy(src_path, dest_path / duplicate_vm.os)
+
+            vm_xml = build_xml(VmCreateXML(**duplicate_vm.model_dump()))
+
+            try:
+                conn = QEMUConfig.get_connection()
+                conn.defineXML(vm_xml)
+                session.add(duplicate_vm)
+                session.commit()
+            except Exception as e:
+                if dest_path.exists():
+                    rmtree(dest_path)
+                raise HTTPException(
+                    status_code=500,
+                    detail=f"Failed to duplicate VM: {str(e)}"
+                )
+
+            return Vm.get(str(duplicate_vm.id))