Skip to content

[Request] NeoForge 26.1.2 — Uncrafting Table recipe is not recognized #108

Description

@NanayaQ

I'm using UncraftingTable-neoforge-1.5.6-fix.1.jar on NeoForge 26.1.2.95.

The Uncrafting Table itself loads correctly and can be given with:

/give @s uncraftingtable76:uncraftingtable

However, the crafting recipe is not recognized by Minecraft or JEI. JEI shows the Uncrafting Table as having no crafting recipe, and the table cannot be crafted using the documented recipe of 8 diamonds surrounding a crafting table.

I inspected the JAR and found the recipe at:

data/uncraftingtable76/recipes/uncraftingtable.json

The current recipe uses:

{
  "type": "minecraft:crafting_shaped",
  "pattern": [
    "###",
    "#X#",
    "###"
  ],
  "key": {
    "X": {
      "item": "minecraft:crafting_table"
    },
    "#": {
      "item": "minecraft:diamond"
    }
  },
  "result": {
    "item": "uncraftingtable76:uncraftingtable",
    "count": 1
  }
}

It appears that Minecraft 26.1.2 uses the newer recipe result structure, where the result is specified using "id" instead of "item".

I manually changed than recipes folder to "recipe" [data/uncraftingtable76/recipe/uncraftingtable.json] and update recipe in uncraftingtable.json to:

{
  "type": "minecraft:crafting_shaped",
  "category": "misc",
  "group": "uncraftingtable76",
  "key": {
    "#": "minecraft:diamond",
    "X": "minecraft:crafting_table"
  },
  "pattern": [
    "###",
    "#X#",
    "###"
  ],
  "result": {
    "id": "uncraftingtable76:uncraftingtable"
  }
}

and after making this change, JEI immediately recognized the recipe and the Uncrafting Table could be crafted normally.

The rest of the recipe remained the same.

I'm assuming the recipe format needs to be updated for the newer Minecraft 26.1.x recipe structure. Older Minecraft versions may still require the previous format, so this may need to be applied only to the appropriate versions?

Tested and confirm working after crafting the uncrafting table.

Environment:

Minecraft: 26.1.2
NeoForge: 26.1.2.95
Uncrafting Table: 1.5.6-fix.1
MCPitanLib: 4.0.7-26.1
JEI: 29.29.0.77

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions