Merge pull request #32 from Particular/hotfix-5.1.1

Change Validate to run all checks for type

Author: WilliamBZA

src/NServiceBus.Testing.Tests/InvocationTests.cs

@@ -171,6 +171,20 @@ public void DeferMessageBasicNegative()
 
             exp.Validate(i);
         }
+
+        [Test]
+        public void RunAllInvocations()
+        {
+            var invocationCount = 0;
+
+            var i = new PublishInvocation<MessageA> { Message = new MessageA() };
+            var j = new PublishInvocation<MessageA> { Message = new MessageA() };
+            var exp = new ExpectedPublishInvocation<MessageA> { Check = m => { invocationCount++;  return true; } };
+
+            exp.Validate(i, j);
+
+            Assert.That(() => invocationCount, Is.EqualTo(2));
+        }
     }
 
     public class MessageA

src/NServiceBus.Testing/Invocations.cs

@@ -15,13 +15,10 @@ abstract class ExpectedInvocation<T> : IExpectedInvocation where T : ActualInvoc
     {
         public void Validate(params ActualInvocation[] invocations)
         {
-            var calls = invocations.Where(i => typeof(T) == i.GetType());
-            var success = calls.Any(c =>
-                                         {
-                                             var result = Validate(c as T);
-                                             
-                                             return result;
-                                         });
+            var calls = invocations.Where(i => typeof(T) == i.GetType()).Cast<T>();
+            var callResults = calls.Select(c => Validate(c)).ToArray(); // Force enumeration
+
+            var success = callResults.Any(result => result);
 
             if ((!success && !Negate) || (Negate && success))
                 throw new Exception(string.Format("{0} not fulfilled.\nCalls made:\n{1}", filter(GetType()), string.Join("\n", invocations.Select(i => filter(i.GetType())))));