Merge pull request #126 from Opteo/v19

v19 build from protos

Author: Lewis-Clayton

.github/workflows/test.yml

@@ -23,7 +23,7 @@ jobs:
         id: yarn-cache-dir-path
         run: echo "::set-output name=dir::$(yarn cache dir)"
 
-      - uses: actions/cache@v1
+      - uses: actions/cache@v4
         id: yarn-cache
         with:
           path: ${{ steps.yarn-cache-dir-path.outputs.dir }}

Makefile

@@ -1,6 +1,6 @@
 # Google Ads API version
 # This only needs changing for major versions e.g. v8 -> v9
-GOOGLE_ADS_VERSION=v17
+GOOGLE_ADS_VERSION=v19
 
 BUNDLE=googleads-nodejs.tar.gz
 PACKAGE_BUILD=/package/googleads-nodejs

README.md

@@ -46,7 +46,9 @@ npm install google-ads-node
 1. Run `make protos` to pull in the new protos and compile them. This command will take around 10 minutes. There are often errors here that need to be fixed due to changes in bazel, the docker image, or the protos themselves. Fix these errors as they come up.
 1. If upgrading to a new major version delete the old version folders from `package/googleads-nodejs/protos/google/ads/googleads/{OLD_VERSION}`, `package/googleads-nodejs/src/{OLD_VERSION}` and `package/googleads-nodejs/samples/generated/{OLD_VERSION}`.
 1. Run `yarn` to prepare the package and install the latest dependencies.
-1. Run `yarn test` to make sure everything worked (you may need to update the version numbers here).
+1. You may find that the tsc build fails because of camelcase issues. If so, make sure that the `compile-protos` command in `/package/googleads-nodejs/package.json` includes all required arguments, like so: `compileProtos --keep-case --force-number src`
+1. Update any references to old version numbers in `tests/protos.js`.
+1. Run `yarn test` to make sure everything worked.
 1. Double check that any files that should have been updated have been.
 1. Update the readme to reflect the new Google Ads API version number
 1. Make a pull request, get it approved and merged into `master`.

package.json

@@ -1,6 +1,6 @@
 {
   "name": "google-ads-node",
-  "version": "14.0.0",
+  "version": "15.0.0",
   "description": "Google Ads API client library",
   "main": "build/src/index.js",
   "files": [
@@ -30,5 +30,6 @@
     "ads node",
     "grpc",
     "proto"
-  ]
+  ],
+  "packageManager": "yarn@1.22.21+sha1.1959a18351b811cdeedbd484a8f86c3cc3bbaf72"
 }

package/googleads-nodejs/.jsdoc.js

@@ -1,4 +1,4 @@
-// Copyright 2024 Google LLC
+// Copyright 2025 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -40,7 +40,7 @@ module.exports = {
     includePattern: '\\.js$'
   },
   templates: {
-    copyright: 'Copyright 2024 Google LLC',
+    copyright: 'Copyright 2025 Google LLC',
     includeDate: false,
     sourceFiles: false,
     systemName: 'google-ads',

package/googleads-nodejs/.mocharc.js

@@ -1,4 +1,4 @@
-// Copyright 2024 Google LLC
+// Copyright 2025 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

package/googleads-nodejs/.prettierrc.js

@@ -1,4 +1,4 @@
-// Copyright 2024 Google LLC
+// Copyright 2025 Google LLC
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

package/googleads-nodejs/package.json

@@ -32,8 +32,6 @@
     "ad group criterion label service",
     "ad group criterion service",
     "ad group customizer service",
-    "ad group extension setting service",
-    "ad group feed service",
     "ad group label service",
     "ad group service",
     "ad parameter service",
@@ -61,13 +59,12 @@
     "campaign criterion service",
     "campaign customizer service",
     "campaign draft service",
-    "campaign extension setting service",
-    "campaign feed service",
     "campaign group service",
     "campaign label service",
     "campaign lifecycle goal service",
     "campaign service",
     "campaign shared set service",
+    "content creator insights service",
     "conversion action service",
     "conversion adjustment upload service",
     "conversion custom variable service",
@@ -82,8 +79,6 @@
     "customer client link service",
     "customer conversion goal service",
     "customer customizer service",
-    "customer extension setting service",
-    "customer feed service",
     "customer label service",
     "customer lifecycle goal service",
     "customer manager link service",
@@ -94,15 +89,9 @@
     "customer user access service",
     "custom interest service",
     "customizer attribute service",
+    "data link service",
     "experiment arm service",
     "experiment service",
-    "extension feed item service",
-    "feed item service",
-    "feed item set link service",
-    "feed item set service",
-    "feed item target service",
-    "feed mapping service",
-    "feed service",
     "geo target constant service",
     "google ads field service",
     "google ads service",
@@ -148,22 +137,24 @@
     "test": "c8 mocha build/test"
   },
   "devDependencies": {
-    "@types/mocha": "^10.0.6",
-    "@types/node": "^20.12.12",
+    "@types/mocha": "^10.0.7",
+    "@types/node": "^20.16.4",
     "@types/sinon": "^10.0.20",
-    "c8": "^9.1.0",
-    "gapic-tools": "^0.4.2",
-    "google-gax": "^4.4.1",
-    "gts": "5.3.0",
+    "c8": "^10.1.2",
+    "gapic-tools": "^0.4.6",
+    "gts": "5.3.1",
     "jsdoc": "^4.0.3",
     "jsdoc-fresh": "^3.0.0",
     "jsdoc-region-tag": "^3.0.0",
-    "mocha": "^10.4.0",
+    "mocha": "^10.7.3",
     "pack-n-play": "^2.0.3",
-    "sinon": "^15.2.0",
+    "sinon": "^18.0.0",
     "typescript": "5.1.6"
   },
   "engines": {
     "node": ">=v14"
+  },
+  "dependencies": {
+    "google-gax": "^4.4.1"
   }
 }