-
Notifications
You must be signed in to change notification settings - Fork 10
Open
Labels
deprecationThis issue pertains to an item/topic which has been deprecatedThis issue pertains to an item/topic which has been deprecated
Description
Summary
A JDBC helper is explicitly marked deprecated and retained only for legacy conversion behavior.
Evidence
src/puppetlabs/puppetdb/jdbc.clj:228defines^:deprecated call-with-array-converted-query-rows.src/puppetlabs/puppetdb/jdbc.clj:238docstring says it is deprecated and callers should prefercall-with-query-rowswith explicit conversions.
Proposed OpenVoxDB 9 Change
- Remove
call-with-array-converted-query-rows. - Require callers to use
call-with-query-rowsand explicit value conversions where needed.
Compatibility / Risk
- Low to medium risk depending on internal call sites and extensions.
- Clear replacement API already exists.
Implementation Notes
- Verify no internal usages remain before deletion.
- If external API surface matters, provide a temporary shim with explicit failure guidance.
Acceptance Criteria
- Deprecated JDBC helper is removed.
- No internal usages remain.
- Query behavior is preserved via explicit conversions where necessary.
Suggested Tests
- Query row conversion tests using non-deprecated path.
- Regression tests for SQL array conversion logic where still required.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
deprecationThis issue pertains to an item/topic which has been deprecatedThis issue pertains to an item/topic which has been deprecated
Type
Projects
Status
Deprecated