Skip to content

[Deprecation] jdbc/call-with-array-converted-query-rows #210

@silug

Description

@silug

Summary

A JDBC helper is explicitly marked deprecated and retained only for legacy conversion behavior.

Evidence

  • src/puppetlabs/puppetdb/jdbc.clj:228 defines ^:deprecated call-with-array-converted-query-rows.
  • src/puppetlabs/puppetdb/jdbc.clj:238 docstring says it is deprecated and callers should prefer call-with-query-rows with explicit conversions.

Proposed OpenVoxDB 9 Change

  • Remove call-with-array-converted-query-rows.
  • Require callers to use call-with-query-rows and explicit value conversions where needed.

Compatibility / Risk

  • Low to medium risk depending on internal call sites and extensions.
  • Clear replacement API already exists.

Implementation Notes

  • Verify no internal usages remain before deletion.
  • If external API surface matters, provide a temporary shim with explicit failure guidance.

Acceptance Criteria

  • Deprecated JDBC helper is removed.
  • No internal usages remain.
  • Query behavior is preserved via explicit conversions where necessary.

Suggested Tests

  • Query row conversion tests using non-deprecated path.
  • Regression tests for SQL array conversion logic where still required.

Metadata

Metadata

Assignees

No one assigned

    Labels

    deprecationThis issue pertains to an item/topic which has been deprecated

    Type

    No type

    Projects

    Status

    Deprecated

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions