Skip to content

[Deprecation] Obsolete Config Key Redirections #203

@silug

Description

@silug

Summary

OpenVoxDB still auto-redirects obsolete configuration keys to newer replacements.

Evidence

  • src/puppetlabs/puppetdb/config.clj:38 defines redirect-obsolete-config-setting.
  • src/puppetlabs/puppetdb/config.clj:262 redirects :facts-blacklist -> :facts-blocklist.
  • src/puppetlabs/puppetdb/config.clj:263 redirects :facts-blacklist-type -> :facts-blocklist-type.
  • src/puppetlabs/puppetdb/config.clj:491 redirects :certificate-whitelist -> :certificate-allowlist.
  • test/puppetlabs/puppetdb/config_test.clj:129 verifies redirection behavior.

Proposed OpenVoxDB 9 Change

  • Remove automatic redirection for obsolete keys.
  • Reject obsolete keys with clear startup/config error and migration message.

Compatibility / Risk

  • Medium risk for installations with old config keys still present.
  • Migration is straightforward key rename.

Implementation Notes

  • Keep duplicate-key conflict errors.
  • Add explicit messages listing old and new keys.

Acceptance Criteria

  • Obsolete keys are no longer silently rewritten.
  • Config load fails fast (or hard-warns per final policy) when obsolete keys are present.
  • Docs/config samples only use replacement keys.

Suggested Tests

  • Config tests for obsolete-key rejection.
  • Migration-message tests for each retired key pair.

Metadata

Metadata

Assignees

No one assigned

    Labels

    deprecationThis issue pertains to an item/topic which has been deprecated

    Type

    No type

    Projects

    Status

    Deprecated

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions