Skip to content

Commit 4e90828

Browse files
committed
advanced-features: azure-recording-tutorials - more changes to the S3 references
1 parent 7507667 commit 4e90828

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

advanced-features/openvidu-recording-advanced-node-azure/.env

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ RECORDINGS_PATH=recordings/
1010
RECORDING_PLAYBACK_STRATEGY=AZURE
1111

1212
# Azure Blob Storage configuration
13-
AZURE_ACCOUNT_NAME=yourstorageaccountname
14-
AZURE_ACCOUNT_KEY=youraccountkey
13+
AZURE_ACCOUNT_NAME=your_account_name
14+
AZURE_ACCOUNT_KEY=your_account_key
1515
AZURE_CONTAINER_NAME=openvidu-appdata

advanced-features/openvidu-recording-advanced-node-azure/src/controllers/recording.controller.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ recordingController.get("/:recordingName", async (req, res) => {
102102
});
103103

104104
recordingController.get("/:recordingName/url", async (req, res) => {
105+
console.log("Getting recording URL...");
105106
const { recordingName } = req.params;
106107
const exists = await recordingService.existsRecording(recordingName);
107108

advanced-features/openvidu-recording-advanced-node-azure/src/services/azure.blobstorage.service.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,18 +81,18 @@ export class AzureBlobService {
8181
downloadResponse = await blobClient.download();
8282
}
8383
if (!downloadResponse.readableStreamBody) {
84-
throw new Error("No se pudo obtener el stream del blob");
84+
throw new Error("Could not obtain the blob stream");
8585
}
8686
return downloadResponse.readableStreamBody;
8787
}
8888

8989
// Generates a valid SAS URL for 24 hours
9090
async getObjectUrl(key) {
9191
if (!AZURE_ACCOUNT_NAME || !AZURE_ACCOUNT_KEY) {
92-
throw new Error("Credenciales de cuenta de Azure no están definidas para generar SAS");
92+
throw new Error("Azure account credentials are not defined to generate SAS");
9393
}
9494
const blobClient = this.containerClient.getBlobClient(key);
95-
const expiresOn = new Date(new Date().valueOf() + 24 * 60 * 60 * 1000); // 24 horas
95+
const expiresOn = new Date(new Date().valueOf() + 24 * 60 * 60 * 1000); // 24 hours
9696
const sasPermissions = BlobSASPermissions.parse("r");
9797
const sasToken = generateBlobSASQueryParameters(
9898
{

0 commit comments

Comments
 (0)