Width and Height are ignored when the frame rate is `float`

[ericfortis]

Background

• The format tag requires a name from this predefined list, for example:

FFVideoFormat3840x2160p60
FFVideoFormat3840x2160p5994

• When the format tag has frameDuration, width, height, their values take precedence over deriving them from the name.

• The adapter is currently generating that tag like this:

 <format id="r1" frameDuration="1/50s" name="FFVideoFormat3840x2160p50" />

Problem

An otio file with a rate such as 50.0 gets converted to FFVideoFormat3840x2160p50.0, so that trailing .0 invalidates the name. Therefore,

• In Final Cut Pro the project doesn’t get the correct video size (it defaults to 1280x720)

• When importing the XML, there’s this warning

Proposed Solution

Since name can be overriden (although it’s required) we could always use a valid value from that list such as: FFVideoFormat3840x2160p60, along with the attributes. For example,

 <format id="r1" frameDuration="1/50s" width="1280" height="720" name="FFVideoFormat3840x2160p50" />

I tried using name="", no luck. Also tried name="FFVideoFormatRateUndefined", but that also triggers the warning. That value seems to be for audio-only projects, which are also breaking but that’s out of the scope of this ticket.

I think that trying to generate actual predefined values is not worth the effort because it doesn’t work for custom sizes anyways. Also, because an otio file can have a rate like this 59.94005994005994, which would have to be converted to 5994 in order to match a predefined name.

LMK

---

Edit: I tested v1.13 and name is not required if colorSpace is present. At any rate, hardcoding a dummy name is easier than computing the color space.

[ericfortis]

FWIW, since name is not required when colorSpace is present, here’s a function that takes ffprobe attrs as input

def color_space(color_primaries, color_trc, colorspace):
  return {
    ('bt709', 'bt709', 'bt709'): '1-1-1',
    ('smpte170m', 'bt709', 'smpte170m'): '6-1-6',
    ('bt470bg', 'bt709', 'smpte170m'): '5-1-6',
    ('bt2020', 'bt709', 'bt2020nc'): '9-1-9',
    ('bt2020', 'smpte2084', 'bt2020nc'): '9-16-9',
    ('bt2020', 'arib-std-b67', 'bt2020nc'): '9-18-9',
  }.get((color_primaries, color_trc, colorspace), '1-1-1')