Skip to content

Commit d2e4cd0

Browse files
authored
Remove notifier module (#1237)
2 parents 0138691 + ded4ced commit d2e4cd0

File tree

9 files changed

+16
-343
lines changed

9 files changed

+16
-343
lines changed

.env.example

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ OTA_ENGINE_GITHUB_TOKEN=your_github_token_here
55
OTA_ENGINE_GITLAB_TOKEN=your_gitlab_token_here
66
OTA_ENGINE_GITLAB_RELEASES_TOKEN=your_gitlab_releases_token_here
77
OTA_ENGINE_DATAGOUV_API_KEY=your_datagouv_api_key_here
8-
OTA_ENGINE_SENDINBLUE_API_KEY=your_sendinblue_api_key_here
98
OTA_ENGINE_SMTP_PASSWORD=your_smtp_password_here
109

1110
HTTP_PROXY=http://proxy.example.com:8080

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,15 @@
22

33
All changes that impact users of this module are documented in this file, in the [Common Changelog](https://common-changelog.org) format with some additional specifications defined in the CONTRIBUTING file. This codebase adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
44

5+
## Unreleased [major]
6+
7+
> Development of this release was supported by the [NGI0 Commons Fund](https://nlnet.nl/project/Modular-OTA/), a fund established by [NLnet](https://nlnet.nl/) with financial support from the European Commission's [Next Generation Internet](https://www.ngi.eu) programme, under the aegis of DG CNECT under grant agreement N°101069594.
8+
9+
### Removed
10+
11+
- Remove Notifier module
12+
- **Breaking:** Remove all default SMTP values (`host`, `port`, `username`) from logger configuration; operators enabling `sendMailOnError` must now explicitly set all three in [`@opentermsarchive/engine.logger.smtp`](https://docs.opentermsarchive.org/collections/reference/configuration/#logger)
13+
514
## 10.6.1 - 2026-02-05
615

716
> Development of this release was supported by [Reset Tech](https://www.reset.tech).

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ There are five ways to handle operational errors:
218218
- **Log the error — and do nothing else**. If it's a minor error and there’s nothing you can do about, and there is no reason to stop the whole process.
219219
- **Crash immediately**. If the error cannot be handled and can affect data integrity.
220220

221-
In our case, we consider all `fetch`-related and `extract`-related errors as expected, so as operational errors and we handle them by logging but we do not stop the whole process. We handle errors related to the `notifier` in the same way.
221+
In our case, we consider all `fetch`-related and `extract`-related errors as expected, so as operational errors and we handle them by logging but we do not stop the whole process.
222222
In contrast, we consider errors from the `recorder` module as fatal, and we crash immediately.
223223

224224
#### Handling programmer errors

config/default.json

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -42,20 +42,9 @@
4242
"language": "en"
4343
},
4444
"logger": {
45-
"smtp": {
46-
"host": "smtp-relay.brevo.com",
47-
"port": 587,
48-
"username": "admin@opentermsarchive.org"
49-
},
5045
"sendMailOnError": false,
5146
"timestampPrefix": true
5247
},
53-
"notifier": {
54-
"sendInBlue": {
55-
"updatesListId": 850,
56-
"updateTemplateId": 7
57-
}
58-
},
5948
"dataset": {
6049
"publishingSchedule": "30 8 * * MON"
6150
}

package-lock.json

Lines changed: 6 additions & 169 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@
9595
"puppeteer": "^24.22.0",
9696
"puppeteer-extra": "^3.3.6",
9797
"puppeteer-extra-plugin-stealth": "^2.11.2",
98-
"sib-api-v3-sdk": "^8.5.0",
9998
"simple-git": "^3.28.0",
10099
"swagger-jsdoc": "^6.2.8",
101100
"swagger-ui-express": "^5.0.1",

0 commit comments

Comments
 (0)