Skip to content

Commit 51d5aab

Browse files
authored
Fix image rendering and add vector glyph support (#816)
1 parent 6c991c1 commit 51d5aab

9 files changed

Lines changed: 611 additions & 72 deletions

File tree

Example/OpenSwiftUIUITests/View/Image/NamedImageUITests.swift

Lines changed: 60 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,10 @@ import Testing
77
@testable import TestingHost
88

99
@MainActor
10-
@Suite(.snapshots(record: .never, diffTool: diffTool))
10+
@Suite(
11+
.snapshots(record: .never, diffTool: diffTool),
12+
.disabled("#817")
13+
)
1114
struct NamedImageUITests {
1215
@Test("Test named image of logo with resizable")
1316
func decorativeLogo() {
@@ -45,4 +48,60 @@ struct NamedImageUITests {
4548
}
4649
openSwiftUIAssertSnapshot(of: ContentView())
4750
}
51+
52+
@Test("Test different symbol varient")
53+
func symbolVarient() {
54+
struct ContentView: View {
55+
let name = "document"
56+
var body: some View {
57+
VStack {
58+
Image(systemName: name)
59+
Image(systemName: name)
60+
.symbolVariant(.circle)
61+
Image(systemName: name)
62+
.symbolVariant(.fill)
63+
}
64+
}
65+
}
66+
openSwiftUIAssertSnapshot(of: ContentView())
67+
}
68+
69+
@Test("Test symbol image with variable value")
70+
func symbolImageWithVariableValue() {
71+
struct ContentView: View {
72+
let name: String = "speaker.wave.3"
73+
var body: some View {
74+
VStack {
75+
Image(systemName: name, variableValue: 0)
76+
Image(systemName: name, variableValue: 0.33)
77+
Image(systemName: name, variableValue: 0.67)
78+
Image(systemName: name, variableValue: 1)
79+
}
80+
}
81+
}
82+
openSwiftUIAssertSnapshot(of: ContentView())
83+
}
84+
85+
@Test(
86+
"Test symbol image with different rendering mode",
87+
.disabled("renderVectorGlyph is not supported yet")
88+
)
89+
func symbolImageRenderingMode() {
90+
struct ContentView: View {
91+
let name: String = "gear"
92+
var body: some View {
93+
VStack(spacing: .zero) {
94+
Image(systemName: name)
95+
.foregroundStyle(.red)
96+
Image(systemName: name)
97+
.symbolRenderingMode(.multicolor)
98+
.foregroundStyle(.red, .blue)
99+
Image(systemName: name)
100+
.symbolRenderingMode(.palette)
101+
.foregroundStyle(.red, .blue)
102+
}.symbolVariant(.circle)
103+
}
104+
}
105+
openSwiftUIAssertSnapshot(of: ContentView())
106+
}
48107
}

Example/Shared/ContentView.swift

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
//
22
// ContentView.swift
33
// Shared
4-
//
5-
// Created by Kyle on 2023/11/9.
6-
//
74

85
#if OPENSWIFTUI
96
import OpenSwiftUI
@@ -13,6 +10,6 @@ import SwiftUI
1310

1411
struct ContentView: View {
1512
var body: some View {
16-
NamedImageExample()
13+
SunsetSceneExample()
1714
}
1815
}

0 commit comments

Comments
 (0)