Skip to content

Commit 5d70182

Browse files
Bump com.fasterxml.jackson.core:jackson-core from 2.12.3 to 2.17.1 (#110)
* Bump com.fasterxml.jackson.core:jackson-core from 2.12.3 to 2.17.1 Bumps [com.fasterxml.jackson.core:jackson-core](https://github.com/FasterXML/jackson-core) from 2.12.3 to 2.17.1. - [Commits](FasterXML/jackson-core@jackson-core-2.12.3...jackson-core-2.17.1) --- updated-dependencies: - dependency-name: com.fasterxml.jackson.core:jackson-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Enable INCLUDE_SOURCE_IN_LOCATION to maintain error message --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sebastian Berlin <[email protected]>
1 parent 907753e commit 5d70182

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
<properties>
2323
<openrefine.version>3.6-SNAPSHOT</openrefine.version>
24-
<jackson.version>2.12.3</jackson.version>
24+
<jackson.version>2.17.1</jackson.version>
2525
<wdtk.version>0.12.1-SNAPSHOT</wdtk.version>
2626
<swc-parser-lazy.version>3.1.9</swc-parser-lazy.version>
2727
<surefire.version>3.2.5</surefire.version>

src/main/java/org/openrefine/extensions/commons/importer/RelatedCategoryFetcher.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import java.util.Iterator;
66
import java.util.List;
77

8+
import com.fasterxml.jackson.core.JsonParser.Feature;
89
import com.fasterxml.jackson.databind.JsonNode;
910
import com.fasterxml.jackson.databind.ObjectMapper;
1011

@@ -68,7 +69,9 @@ public List<List<String>> getRelatedCategories(List <FileRecord> fileRecordOrigi
6869
.addQueryParameter("format", "json").build();
6970
Request request = new Request.Builder().url(urlRelatedCategoriesBase).build();
7071
Response response = client.newCall(request).execute();
71-
JsonNode jsonNode = new ObjectMapper().readTree(response.body().string());
72+
JsonNode jsonNode = new ObjectMapper().enable(
73+
Feature.INCLUDE_SOURCE_IN_LOCATION)
74+
.readTree(response.body().string());
7275
List<JsonNode> relatedCategories = new ArrayList<>();
7376
List<List<String>> toCategoriesColumn = new ArrayList<>();
7477
for (int i = 0; i < fileRecordOriginal.size(); i++) {

src/test/java/org/openrefine/extensions/commons/importer/RelatedCategoryFetcherTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ public void testNextError() throws Exception {
123123
Assert.assertFalse(rcf.hasNext());
124124
String error = "Could not fetch related categories: Unexpected character ('{' (code 123)): was expecting double-quote to start field name"
125125
+ "\n at [Source: (String)\"{\"batchcomplete\":\"\",\"query\":{\"pages\":{\"127723\":{\"pageid\":127723,\"ns\":6,"
126-
+ "\"title\":\"File:LasTres_2.jpg\",{\"ns\":14,\"title\":\"Category:Cute dogs\"},{\"ns\":14,\"title\":\"Category:Costa Rican dogs\"}]}}}}\"; line: 1, column: 102]";
126+
+ "\"title\":\"File:LasTres_2.jpg\",{\"ns\":14,\"title\":\"Category:Cute dogs\"},{\"ns\":14,\"title\":\"Category:Costa Rican dogs\"}]}}}}\"; line: 1, column: 101]";
127127
List<String> categories = Arrays.asList("Category:Costa Rica", "Category:Cute dogs", "Category:Costa Rican dogs");
128128
FileRecord file0 = new FileRecord("File:LasTres_2.jpg", "127723", null, error);
129129
FileRecord file1 = new FileRecord("File:LasTres.jpg", "127722", categories, null);

0 commit comments

Comments
 (0)