Cyclic trainruns one-way's cards keep swapping

[louisgreiner]

What is the input mode?

Mouse

What type of issue is it?

Functionality

What happened?

Following of #843
(work done here #843 (comment))

When trainrun is a cycle, the one way cards keep swapping.

552701437-c4fdd632-99f0-4149-8b5f-236967ba9603.webm

What did you expect to happen?

Cards should keep the same position

How can we reproduce it (as minimally and precisely as possible)?

video

On which environments the bug occurs?

Local

On which browser the bug occurs?

Firefox

Netzgrafik-Editor version (top left corner Version x.yy.zz)

2.10.14

[aiAdrian]

The jumping around in the order only occurs for train runs where the start and end node are the same node (cyclic) and the train run is one‑way.

In that case, the usual logic no longer works — the left/right node depends on the direction. This must be handled manually.
I just came up with the following heuristic: We might simply say that the first node is the one with the smaller oppositeNode ID. Because the invertTrainrunSectionsSourceAndTarget changes as well the "left/right" ordering - which should be static. I understand that this is very tricky to solve.

if (this.leftNode === this.rightNode) {
  // Cyclic trainrun
  // This ensures the two cards represent different directions
  this.trainrunSectionService.invertTrainrunSectionsSourceAndTarget(
    trainrunSection.getTrainrunId(),
  );
}

We could potentially sort by order (trainrun section ID) if the result is not unique. This could even be applied globally.

[louisgreiner]

Indeed, this could work yes 👍

[louisgreiner]

Mmmh, I tried some conditions as you suggested, but actually none of them is agnostic of the source->target paradigm... Actually, inverting a trainrun section actually inverts all the attributes I could find... I don't know what to do then. Here is what I tried, if this can help you, in src/app/view/dialogs/trainrun-and-section-dialog/trainrunsection-card/trainrun-section-card.component.ts:

  updateAllValues() {
    const selectedTrainrun = this.trainrunService.getSelectedTrainrun();
    if (!selectedTrainrun) {
      return;
    }
    const firstTrainrunSection = this.trainrunService.getFirstTrainrunSection(selectedTrainrun);

    this.leftNode = this.trainrunService.getLeftOrTopNodeWithTrainrunId(
      firstTrainrunSection.getTrainrunId(),
    );
    this.rightNode = this.trainrunService.getRightOrBottomNodeWithTrainrunId(
      firstTrainrunSection.getTrainrunId(),
    );

    this.trainrunSectionTimesService.setOffset(0);
    if (selectedTrainrun.isRoundTrip()) {
      // Initialize round trip trainrun with top card
      this.onTrainrunSectionCardClick("top");
    } else {
      if (this.leftNode === this.rightNode) {
        // Cyclic trainrun
        // This ensures the two cards represent different directions
        const lastTrainrunSection = this.trainrunService.getLastTrainrunSection(selectedTrainrun);
        const condition = firstTrainrunSection.getId() < lastTrainrunSection.getId();
        const condition =
          this.leftNode.getOppositeNode(firstTrainrunSection).getId() <
          this.leftNode.getOppositeNode(lastTrainrunSection).getId();
        const condition =
          firstTrainrunSection.getSourceDeparture() < lastTrainrunSection.getTargetArrival();
        const condition =
          firstTrainrunSection.getSourceArrivalConsecutiveTime() <
          lastTrainrunSection.getTargetArrivalConsecutiveTime();
        if (cond) {
          this.chosenCard = "top";
        } else {
          this.chosenCard = "bottom";
        }
      } else {
        // Non-cyclic trainrun
        // Initialize one-way trainrun with card that represents the current direction
        this.chosenCard = this.trainrunService.isTrainrunTargetRightOrBottom() ? "top" : "bottom";
      }
    }

    this.trainrunSectionTimesService.setTrainrunSection(firstTrainrunSection);
    this.frequencyLinePattern = firstTrainrunSection.getFrequencyLinePatternRef();
    this.categoryColorRef = selectedTrainrun.getCategoryColorRef();
    this.timeCategoryLinePattern = selectedTrainrun.getTimeCategoryLinePatternRef();
    this.trainrunSectionTimesService.setHighlightTravelTimeElement(false);
    this.trainrunSectionTimesService.applyOffsetAndTransformTimeStructure();
  }