Skip to content

Finish interface non-LM QA tasks #2408

@filiperochalopes

Description

@filiperochalopes

User story

As a user, I want Interface QA to apply the updated FR severities and rules so I can see which issues block saving (Errors) and which are advisory only (Warnings).

Use case

Edit a concept in the UI, run Interface QA, review the findings, and save only when there are no blocking Errors.

Requirements

  • Apply the revised severity model in Interface QA:
    • Error = blocking (prevents save/submission)
    • Warning = non-blocking (advisory only; must not block save)
  • Implement/enable FR rules in Interface QA with the updated severities:
    • FR-12 (Error): No duplicate mappings within a concept (same (source, code) must not repeat)
    • FR-15 (Error): No HTML entities in names or descriptions
    • FR-19 (Warning): No disjunctions in preferred names (recommendation only)
    • FR-21 (Warning): Units in name vs metadata (recommendation only; equivalence acceptable)
    • FR-22 (Warning): Retired/inactive SNOMED CT code notification (notification only)
    • FR-23 (Warning): Residual ICD codes should avoid SAME-AS (recommendation only)
    • FR-25 (Error): No multiple SAME-AS mappings to the same source within a concept
  • Do not implement FR-24 (cancelled).
  • Ensure save behavior respects severity:
    • Any Error blocks save
    • Warnings do not block save

Acceptance criteria

  • Given Interface QA runs, findings are classified as Error or Warning according to the updated FR severity table.
  • Given at least one Error finding exists, save is blocked.
  • Given only Warning findings exist, save is allowed.
  • FR-24 is excluded and produces no findings.

More details (collapsible)

Revised FR severity mapping and priority

Errors (blocking)

  • FR-12: No duplicate mappings within a concept
  • FR-15: No HTML entities in names or descriptions
  • FR-25: No multiple SAME-AS mappings to the same source within a concept

Warnings (non-blocking)

  • FR-19: No disjunctions in preferred names
  • FR-21: Units in name vs metadata
  • FR-22: Retired/inactive SNOMED CT code notification
  • FR-23: Residual ICD codes should avoid SAME-AS

Excluded

  • FR-24: cancelled (do not implement)

Suggested priority

  1. FR-12, FR-25, FR-15
  2. FR-22
  3. FR-23, FR-21
  4. FR-19

Metadata

Metadata

Labels

No labels
No labels

Projects

Status

UAT

Relationships

None yet

Development

No branches or pull requests

Issue actions