Enhance log directory handling in alert scripts and logging functions

- Updated `alertRules.sh`, `escalation.sh`, and `sendAlert.sh` to handle log directory creation more gracefully, implementing fallback locations if the primary directory cannot be created due to permission issues.
- Improved `init_logging` in `loggingFunctions.sh` to attempt directory creation first and only use fallback options if necessary, enhancing logging reliability.
- Modified `checkPlanetNotes.sh` to conditionally send alerts based on the availability of the `send_alert` function and the test mode status, improving alert handling in tests.
- Updated unit test script `test_collect_cron_metrics.sh` to ensure the log directory is set correctly for testing, enhancing test reliability.

Author: angoca

bin/alerts/alertRules.sh

@@ -34,8 +34,18 @@ elif [[ -z "${LOG_DIR:-}" ]]; then
  export LOG_DIR="${PROJECT_ROOT}/logs"
 fi
 
-# Ensure log directory exists
-mkdir -p "${LOG_DIR}"
+# Ensure log directory exists (handle permission errors gracefully)
+mkdir -p "${LOG_DIR}" 2>/dev/null || {
+  # If we can't create LOG_DIR, try fallback locations
+  if [[ -n "${TMP_DIR:-}" ]]; then
+    export LOG_DIR="${TMP_DIR}/logs"
+  elif [[ -n "${PROJECT_ROOT:-}" ]] && [[ -d "${PROJECT_ROOT}" ]]; then
+    export LOG_DIR="${PROJECT_ROOT}/tmp/logs"
+  else
+    export LOG_DIR="/tmp/osm-notes-monitoring-logs"
+  fi
+  mkdir -p "${LOG_DIR}" 2>/dev/null || export LOG_DIR="/tmp"
+}
 
 # Initialize logging
 init_logging "${LOG_DIR}/alert_rules.log" "alertRules"

bin/alerts/escalation.sh

@@ -34,8 +34,18 @@ elif [[ -z "${LOG_DIR:-}" ]]; then
  export LOG_DIR="${PROJECT_ROOT}/logs"
 fi
 
-# Ensure log directory exists
-mkdir -p "${LOG_DIR}"
+# Ensure log directory exists (handle permission errors gracefully)
+mkdir -p "${LOG_DIR}" 2>/dev/null || {
+  # If we can't create LOG_DIR, try fallback locations
+  if [[ -n "${TMP_DIR:-}" ]]; then
+    export LOG_DIR="${TMP_DIR}/logs"
+  elif [[ -n "${PROJECT_ROOT:-}" ]] && [[ -d "${PROJECT_ROOT}" ]]; then
+    export LOG_DIR="${PROJECT_ROOT}/tmp/logs"
+  else
+    export LOG_DIR="/tmp/osm-notes-monitoring-logs"
+  fi
+  mkdir -p "${LOG_DIR}" 2>/dev/null || export LOG_DIR="/tmp"
+}
 
 # Only initialize if not in test mode or if script is executed directly
 if [[ "${TEST_MODE:-false}" != "true" ]] || [[ "${BASH_SOURCE[0]}" == "${0}" ]]; then

bin/alerts/sendAlert.sh

@@ -34,8 +34,18 @@ elif [[ -z "${LOG_DIR:-}" ]]; then
  export LOG_DIR="${PROJECT_ROOT}/logs"
 fi
 
-# Ensure log directory exists
-mkdir -p "${LOG_DIR}"
+# Ensure log directory exists (handle permission errors gracefully)
+mkdir -p "${LOG_DIR}" 2>/dev/null || {
+  # If we can't create LOG_DIR, try fallback locations
+  if [[ -n "${TMP_DIR:-}" ]]; then
+    export LOG_DIR="${TMP_DIR}/logs"
+  elif [[ -n "${PROJECT_ROOT:-}" ]] && [[ -d "${PROJECT_ROOT}" ]]; then
+    export LOG_DIR="${PROJECT_ROOT}/tmp/logs"
+  else
+    export LOG_DIR="/tmp/osm-notes-monitoring-logs"
+  fi
+  mkdir -p "${LOG_DIR}" 2>/dev/null || export LOG_DIR="/tmp"
+}
 
 # Only initialize logging if not in test mode
 # When TEST_MODE is true, initialization is skipped to avoid database connections

bin/lib/loggingFunctions.sh

@@ -44,8 +44,9 @@ init_logging() {
   local log_dir
   log_dir="$(dirname "${LOG_FILE}")"
   if [[ ! -d "${log_dir}" ]]; then
-   # In test mode or if we don't have permissions, use a temporary directory
-   if [[ "${TEST_MODE:-false}" == "true" ]] || ! mkdir -p "${log_dir}" 2>/dev/null; then
+   # Try to create the directory first
+   # Only use fallback if creation fails (e.g., no permissions)
+   if ! mkdir -p "${log_dir}" 2>/dev/null; then
     # Use TMP_DIR if set, otherwise try PROJECT_ROOT/tmp/logs, or use /tmp
     local fallback_dir
     if [[ -n "${TMP_DIR:-}" ]]; then

bin/monitor/checkPlanetNotes.sh

@@ -105,15 +105,21 @@ run_planet_check() {
   local planet_duration_threshold="${INGESTION_PLANET_CHECK_DURATION_THRESHOLD:-600}"
   if [[ ${duration} -gt ${planet_duration_threshold} ]]; then
    log_warning "${COMPONENT}: Planet check duration (${duration}s) exceeds threshold (${planet_duration_threshold}s)"
-   send_alert "WARNING" "${COMPONENT}" "Planet Notes check took too long: ${duration}s (threshold: ${planet_duration_threshold}s)"
+   # Only send alert if send_alert function is available and not mocked
+   if command -v send_alert >/dev/null 2>&1 && [[ "${TEST_MODE:-false}" != "true" ]]; then
+    send_alert "WARNING" "${COMPONENT}" "Planet Notes check took too long: ${duration}s (threshold: ${planet_duration_threshold}s)"
+   fi
   fi
 
   return 0
  else
   log_error "${COMPONENT}: Planet Notes check failed (exit_code: ${exit_code}, duration: ${duration}s)"
   record_metric "${COMPONENT}" "planet_check_status" "0" "component=ingestion,check=processCheckPlanetNotes"
   record_metric "${COMPONENT}" "planet_check_duration" "${duration}" "component=ingestion,check=processCheckPlanetNotes"
-  send_alert "ERROR" "${COMPONENT}" "Planet Notes check failed: exit_code=${exit_code}"
+  # Only send alert if send_alert function is available and not mocked
+  if command -v send_alert >/dev/null 2>&1 && [[ "${TEST_MODE:-false}" != "true" ]]; then
+   send_alert "ERROR" "${COMPONENT}" "Planet Notes check failed: exit_code=${exit_code}"
+  fi
   return 1
  fi
 }

tests/unit/monitor/test_collect_cron_metrics.sh

@@ -257,7 +257,11 @@ teardown() {
 	}
 	export -f record_metric
 
+	# Set LOG_DIR to test directory if not already set
+	export LOG_DIR="${LOG_DIR:-${TEST_LOG_DIR}}"
+	
 	# Create a mock log file with old execution times
+	mkdir -p "${LOG_DIR}" 2>/dev/null || export LOG_DIR="${TEST_LOG_DIR}"
 	mkdir -p "${LOG_DIR}"
 	echo "cron_etl_last_execution_seconds 3600" >"${LOG_DIR}/cron_metrics.log"