Refactor logging initialization and test setup for ingestion monitoring

- Updated `monitorIngestion.sh` to initialize logging only when not in test mode or when executed directly, enhancing script behavior.
- Modified test scripts `test_ddosProtection_load.sh`, `test_monitoring_overhead.sh` to set `TEST_MODE` before loading scripts, ensuring consistent test environment setup.
- Adjusted `test_stress_metrics.sh` to disable alert deduplication for specific tests, ensuring all alerts are recorded for accurate testing outcomes.

Author: angoca

bin/monitor/monitorIngestion.sh

@@ -35,8 +35,10 @@ source "${PROJECT_ROOT}/bin/lib/parseStructuredLogs.sh"
 # Set default LOG_DIR if not set
 export LOG_DIR="${LOG_DIR:-${PROJECT_ROOT}/logs}"
 
-# Initialize logging
-init_logging "${LOG_DIR}/ingestion.log" "monitorIngestion"
+# Initialize logging only if not in test mode or if script is executed directly
+if [[ "${TEST_MODE:-false}" != "true" ]] || [[ "${BASH_SOURCE[0]}" == "${0}" ]]; then
+ init_logging "${LOG_DIR}/ingestion.log" "monitorIngestion"
+fi
 
 # Component name
 # Component name (allow override in test mode)

tests/performance/test_ddosProtection_load.sh

@@ -12,7 +12,8 @@ export TEST_DB_NAME="${TEST_DB_NAME:-osm_notes_monitoring_test}"
 
 load "${BATS_TEST_DIRNAME}/../test_helper.bash"
 
-# Set LOG_DIR before loading scripts
+# Set TEST_MODE and LOG_DIR before loading scripts
+export TEST_MODE=true
 export LOG_DIR="${LOG_DIR:-${BATS_TEST_DIRNAME}/../tmp/logs}"
 mkdir -p "${LOG_DIR}"
 

tests/performance/test_monitoring_overhead.sh

@@ -16,7 +16,8 @@ export TEST_DB_NAME="${TEST_DB_NAME:-osm_notes_monitoring_test}"
 
 load "${BATS_TEST_DIRNAME}/../test_helper.bash"
 
-# Set LOG_DIR before loading monitorIngestion.sh
+# Set TEST_MODE and LOG_DIR before loading monitorIngestion.sh
+export TEST_MODE=true
 export LOG_DIR="${LOG_DIR:-${BATS_TEST_DIRNAME}/../tmp/logs}"
 mkdir -p "${LOG_DIR}"
 

tests/performance/test_stress_metrics.sh

@@ -185,6 +185,9 @@ skip_if_database_not_available() {
 @test "Stress test: concurrent alerts and metrics" {
     skip_if_database_not_available
 
+    # Disable alert deduplication for this test to ensure all alerts are recorded
+    export ALERT_DEDUPLICATION_ENABLED="false"
+    
     # Clean up any existing test data
     run_sql_query "DELETE FROM metrics WHERE component = 'ingestion' AND metric_name = 'stress_concurrent';" > /dev/null 2>&1 || true
     run_sql_query "DELETE FROM alerts WHERE component = 'ingestion' AND alert_type = 'stress_alert';" > /dev/null 2>&1 || true
@@ -221,7 +224,7 @@ skip_if_database_not_available() {
     alert_count=$(run_sql_query "SELECT COUNT(*) FROM alerts WHERE component = 'ingestion' AND alert_type = 'stress_alert';" | tr -d ' ' || echo "0")
 
     assert [ "${metric_count}" -eq 50 ]
-    assert [ "${alert_count}" -ge 15 ]  # Some may be deduplicated
+    assert [ "${alert_count}" -eq 20 ]  # All alerts should be recorded when deduplication is disabled
     assert [ "${duration_ms}" -lt 15000 ]
 }