-
Notifications
You must be signed in to change notification settings - Fork 171
Description
Digging into how the Project Manager should handle files when downloads are disabled, I discovered that the current scheme in the Files app of not serving links (which I did in #5024) also affects directories (making navigation impossible).
I also realized that the current scheme disables viewing a file, but still permits editing. It seems strange to leave the file editor as the sole method of interacting with a file. Not sure if the solution is to allow viewing files small enough to be displayed in the browser or to disable editing, but I would have to lean towards the former as the latter would make all files functionally unreadable (at least through the files app), which seems overly restrictive.
Overall I think this shows that we need to strike a balance between avoiding potential permissions errors, and being so safe that we prevent basic functionality because it might cause an error