shell app WSoD on firefox 148

[simonLeary42]

Here's my shell app:

On firefox v147 it works fine, on firefox v148, it's white.

I see this in the developer console:

Uncaught TypeError: can't access property "style", this.screen_ is null
    setBackgroundImage https://ood.unity.rc.umass.edu/pun/sys/shell/javascripts/hterm_all_1.91.mod.js:12797
    image https://ood.unity.rc.umass.edu/pun/sys/shell/javascripts/hterm_all_1.91.mod.js:14418
    notifyChange_ https://ood.unity.rc.umass.edu/pun/sys/shell/javascripts/hterm_all_1.91.mod.js:2849
    notifyAll https://ood.unity.rc.umass.edu/pun/sys/shell/javascripts/hterm_all_1.91.mod.js:2827
    setProfile https://ood.unity.rc.umass.edu/pun/sys/shell/javascripts/hterm_all_1.91.mod.js:14761
hterm_all_1.91.mod.js:12797:3

[johrstrom]

Oh geez, this was just working for me yesterday! I can replicate on Windows FF 148.

[andrewfullard]

Can confirm this is occurring for multiple OS with Firefox 148.

[johrstrom]

Just checked Edge and Chrome on Windows. They work.

[bryank-cs]

Seems like this hack isn't needed anymore: https://chromium.googlesource.com/apps/libapps/+/refs/tags/hterm-1.92/hterm/js/hterm_scrollport.js#548

Removing the conditional worked:

diff --git a/ood/apps/sys/shell/public/javascripts/hterm_all_1.91.mod.js.orig b/ood/apps/sys/shell/public/javascripts/hterm_all_1.91.mod.js
index 936ae4c..9a3a63e 100644
--- a/ood/apps/sys/shell/public/javascripts/hterm_all_1.91.mod.js.orig
+++ b/ood/apps/sys/shell/public/javascripts/hterm_all_1.91.mod.js
@@ -12401,13 +12401,7 @@ hterm.ScrollPort.prototype.decorate = function(div, callback) {
     }
   };

-  // Insert Iframe content asynchronously in FF.  Otherwise when the frame's
-  // load event fires in FF it clears out the content of the iframe.
-  if ('mozInnerScreenX' in window) { // detect a FF only property
-    this.iframe_.addEventListener('load', () => onLoad());
-  } else {
-    onLoad();
-  }
+  onLoad();
 };

[johrstrom]

Thanks! I think I can confirm that block is the issue. I'm writing something around that to check for FF and it's version.

It'll be something like this:

     }
   };
 
+  const agent = window.navigator.userAgent;
+  const versionMatch = agent.match(/Firefox\/(\d+\.\d+)/);
+  let ffVersion = null;
+  if(versionMatch !== null && versionMatch.length == 2) {
+    ffVersion = versionMatch[1];
+  }
+
   // Insert Iframe content asynchronously in FF.  Otherwise when the frame's
   // load event fires in FF it clears out the content of the iframe.
-  if ('mozInnerScreenX' in window) { // detect a FF only property
+  if ('mozInnerScreenX' in window && ffVersion != null && ffVersion < "148.0" ) { // detect a FF only property
     this.iframe_.addEventListener('load', () => onLoad());
   } else {
     onLoad();