File editor blocks other links

[Bubballoo3]

Encountered today on the nightlies, and confirmed that it does not happen on 4.0.8 or in the dev dashboard.

Basically whenever you edit a file, you are unable to click on navbar links to leave the page. It also seems like the wrap and soft tabs options are locked, although I can change all of the select options for font size, theme, etc. Not sure what is causing this, but definitely worth fixing for 4.1

[Bubballoo3]

Just checked and this also happens running the dev container with the nightly from 11/26

[Bubballoo3]

I have narrowed this down to 455e0f0, but still need to go through the packages one by one to see what is causing the issue.

[Bubballoo3]

Narrowed it down once more to the yarn.lock changes in that commit

[Bubballoo3]

I was able to get this working again on master by resolving @hotwired/turbo to v8.0.18, though this will also need turbo-rails locked to 18. I will look through the changes and see if I can find the root issue

[johrstrom]

I was able to get this working again on master by resolving @hotwired/turbo to v8.0.18, though this will also need turbo-rails locked to 18. I will look through the changes and see if I can find the root issue

Yea one interesting thing is this only applies to the file editor page - what's special about that page that would break this?

[Bubballoo3]

I am guessing the confirmation messages are calling something there, though I still can't quite figure out how it would only happen with the minified versions

[Bubballoo3]

And now that I play around with it, this fixes it on the initial load, but still blocks links without confirmation after you make an edit, and you can't save. The saving is likely due to the fact that we send the api request to /sys/ every time

[Bubballoo3]

Ok it looks like the problem I had identified above was just the initial, even before that commit the switches freeze after one is set. (So you can flip either switch once, then they freeze. After the switches freeze, none of the links work either. Notably the links do not produce broken requests like they do in the current version, they do nothing at all. Very confused and worried that we might be dealing with two separate issues happening at the same time. For example, the sticky switches happen as soon as they are introduced in 7d22da3, but do not yet block links after they freeze.