Skip to content

Commit 5dbfdb7

Browse files
author
sreeder
committed
fix method issue by getting by id instead of desc. printing unknown utf-8 characters
1 parent b627a07 commit 5dbfdb7

File tree

3 files changed

+8
-13
lines changed

3 files changed

+8
-13
lines changed

odmtools/gui/pageMethod.py

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,6 @@ def _init_ctrls(self, prnt):
6767
self.lstMethods.SetColumnWidth(2,0)
6868
# self.lstMethods.Enable(False)
6969

70-
71-
72-
7370
def __init__(self, parent, id, pos, size, style, name, ss, method):
7471
self.series_service = ss
7572
self.prev_val = method
@@ -108,26 +105,24 @@ def OnTxtMethodDescripKillFocus(self, event):
108105

109106
event.Skip()
110107

111-
112108
def getMethod(self):
113109

114110
m = Method()
115111
if self.rbGenerate.Value:
116112
genmethod = "Values derived from ODM Tools Python"
117-
m= self.series_service.get_method_by_description(genmethod)
113+
m = self.series_service.get_method_by_description(genmethod)
118114
if m is None:
119115
logger.debug("assigning new method description")
120-
m = Method()
116+
m = Method()
121117
m.description = genmethod
122118

123119
elif self.rbSelect.Value:
124120
index = self.lstMethods.GetFirstSelected()
125-
desc= self.lstMethods.GetItem(index, 0).GetText()
126-
127-
logger.debug(desc)
128-
m= self.series_service.get_method_by_description(desc)
129-
121+
# desc = self.lstMethods.GetItem(index, 0).GetText()
122+
id = self.lstMethods.GetItem(index, 2).GetText()
130123

124+
logger.debug(id)
125+
m = self.series_service.get_method_by_id(int(id))
131126

132127
elif self.rbCreateNew.Value:
133128
logger.debug("assigning new method description")

odmtools/gui/wizSave.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ def fill_summary(self):
187187
self.panel.treeSummary.SetItemText(self.panel.treeSummary.vgc,
188188
'General Category: ' + str(Variable.general_category))
189189

190-
self.panel.treeSummary.SetItemText(self.panel.treeSummary.md, 'Description: ' + str(Method.description))
190+
self.panel.treeSummary.SetItemText(self.panel.treeSummary.md, 'Description: ' + Method.description.encode('utf-8', 'ignore'))
191191

192192
self.panel.treeSummary.SetItemText(self.panel.treeSummary.soo, 'Organization: ' + str(Source.organization))
193193
self.panel.treeSummary.SetItemText(self.panel.treeSummary.sod, 'Description: ' + str(Source.description))

odmtools/odmdata/method.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@ class Method(Base):
99
link = Column('MethodLink', String)
1010

1111
def __repr__(self):
12-
return "<Method('%s', '%s', '%s')>" % (self.id, self.description, self.link)
12+
return "<Method('%s', '%s', '%s')>" % (self.id, self.description.encode("utf-8", 'ignore'), self.link.encode("utf-8", 'ignore'))

0 commit comments

Comments
 (0)