[18.0][ADD] hr_work_entry_timesheet_validate#1525
Open
remi-filament wants to merge 2 commits intoOCA:18.0from
Open
[18.0][ADD] hr_work_entry_timesheet_validate#1525remi-filament wants to merge 2 commits intoOCA:18.0from
remi-filament wants to merge 2 commits intoOCA:18.0from
Conversation
Hugo-Trentesaux
approved these changes
Nov 19, 2025
Contributor
alexey-pelykh
left a comment
alexey-pelykh
left a comment
There was a problem hiding this comment.
Thanks for this. The glue approach between hr_work_entry_timesheet and hr_work_entry_validate makes sense.
Tests pass, but the "Detect unreleased dependencies" check is failing — this depends on modules that haven't been merged into the 18.0 branch yet. Once the dependencies land, this should be good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glue module between hr_work_entry_validate ( #1524 ) and hr_work_entry_timesheet ( #1523 ) to show timesheet on work entry validation interface for employees.