-
Notifications
You must be signed in to change notification settings - Fork 15
Open
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed
Description
Right now GDWeave is locked to 3.5.2 w/ a specific GodotSteam build. We should expand for other engine versions with the following way:
- Detect the engine version somehow.
- Lazy option: call the game binary with --version.
- Write multiple enums and file format implementations.
- We can just have a
VariantType_3_5_2and whatnot. Either codegen or reflect a lookup table to make this speedy. - I don't think the gdc format will change too heavily, but it might require breaking changes.
- To not break the API, the current enums and variant classes can't have anything removed or shifted around. We'll just have to append new variant types to the bottom instead of inserting them in the "proper" locations.
- We can just have a
- Abstract the required hooks into different classes per engine version.
- One version can have multiple engine builds (e.g. diff builds of GodotSteam), so we will have to have the ability to pick a set of hooks and try scanning each one until they match, then create the hooks.
What do we do if the function we want to target is inlined? I don't know! Maybe it'll be time to look into mid-function Reloaded hooks...
Dan-Mizu
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed