Skip to content

Argo workflows error-msg-capture-hook nodeSelector and tolerations propagation #3309

Description

@queimadus

It seems like the default nodeSelector and tolerations added to all step pods (via METAFLOW_KUBERNETES_TOLERATIONS and METAFLOW_KUBERNETES_NODE_SELECTOR), aren't added to the argo workflows error-msg-capture-hook pod, as well.

This makes it so this pod can't re-use the same node from the previous steps.

Is this intended since this is a lightweight pod that should run in a slimmer node?

https://github.com/Netflix/metaflow/blob/master/metaflow/plugins/argo/argo_workflows.py#L3272

https://github.com/Netflix/metaflow/blob/master/metaflow/plugins/argo/argo_workflows.py#L2850-L2853

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions