Skip to content

Commit 795e2b5

Browse files
hellolittlejggao
andauthored
Update worker failure metric (#792)
Co-authored-by: ggao <ggao@netflix.com>
1 parent 8853a81 commit 795e2b5

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

mantis-runtime-executor/src/main/java/io/mantisrx/server/worker/RunningWorker.java

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,7 @@
1818

1919
import static io.mantisrx.server.core.utils.StatusConstants.STATUS_MESSAGE_FORMAT;
2020

21-
import com.netflix.spectator.api.Tag;
22-
import io.mantisrx.common.metrics.Metrics;
23-
import io.mantisrx.common.metrics.MetricsRegistry;
21+
import io.mantisrx.common.metrics.spectator.SpectatorRegistryFactory;
2422
import io.mantisrx.runtime.Context;
2523
import io.mantisrx.runtime.Job;
2624
import io.mantisrx.runtime.MantisJobState;
@@ -160,14 +158,13 @@ public void signalFailed(Throwable t) {
160158
logger.error("Worker failure detected, shutting down job: {}", jobId, t);
161159
// Send failure metrics when data emission failed
162160
if (t instanceof OnErrorThrowable) {
163-
Metrics jobFailureMetrics = new Metrics.Builder()
164-
.id(workerMonitorMetricId, Tag.of("jobId", this.jobId),
165-
Tag.of("workerIndex", String.valueOf(this.workerIndex)),
166-
Tag.of("stageNum", String.valueOf(this.stageNum)))
167-
.addCounter(workerFailureMetricName)
168-
.build();
169-
170-
MetricsRegistry.getInstance().registerAndGet(jobFailureMetrics).getCounter(workerFailureMetricName).increment();
161+
SpectatorRegistryFactory.getRegistry()
162+
.counter("runningWorker_failure",
163+
"jobId", jobId,
164+
"workerIndex", String.valueOf(this.workerIndex),
165+
"stageNum", String.valueOf(this.stageNum)
166+
)
167+
.increment();
171168
}
172169

173170
jobStatus.onNext(new Status(jobId, stageNum, workerIndex, workerNum,

0 commit comments

Comments
 (0)