Conversation
7b80204 to
baf5cff
Compare
📝 WalkthroughWalkthroughThese changes adjust table formatting width, swap a test suite script entrypoint from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can disable sequence diagrams in the walkthrough.Disable the |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/test_suites/nightly_gb200.txt`:
- Around line 17-18: Fix the typo in the comment string "Functional moonlight
run - Disbaled till it can be fixed" by changing "Disbaled" to "Disabled" and
update the adjacent test reference comment line that mentions
"tests/test_suites/llm/grpo-moonlight-16ba3b-4n4g-megatron.sh"; additionally add
a tracking TODO comment like "# TODO(issue#<number>): re-enable
grpo-moonlight-16ba3b-4n4g-megatron.sh when fixed" so the disabled test is
tracked.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 954e3905-a822-4f1e-8293-2b429d6408ac
📒 Files selected for processing (3)
tests/check_metrics.pytests/test_suites/llm/prorlv2-qwen2.5-math-1.5b-instruct-1n8g-fsdp2tp1.shtests/test_suites/nightly_gb200.txt
Signed-off-by: Kajal Jain <kajalj@nvidia.com>
baf5cff to
f704f4a
Compare
|
/ok to test |
@kajalj22, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
|
/ok to test f704f4a |
What does this PR do ?
Fix/disable failing tests
Before your PR is "Ready for review"
Pre checks:
Summary by CodeRabbit