Skip to content

ci: Fix nightly tests#2109

Open
kajalj22 wants to merge 1 commit intomainfrom
kajalj/update-failing-tests
Open

ci: Fix nightly tests#2109
kajalj22 wants to merge 1 commit intomainfrom
kajalj/update-failing-tests

Conversation

@kajalj22
Copy link

@kajalj22 kajalj22 commented Mar 13, 2026

What does this PR do ?

Fix/disable failing tests

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Summary by CodeRabbit

  • Tests
    • Adjusted table layout width in test metrics display.
    • Updated experiment entrypoint in test suite configuration.
    • Disabled moonlight test pending fixes.

@kajalj22 kajalj22 requested a review from a team as a code owner March 13, 2026 17:45
@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 13, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@kajalj22 kajalj22 force-pushed the kajalj/update-failing-tests branch from 7b80204 to baf5cff Compare March 13, 2026 17:48
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026

📝 Walkthrough

Walkthrough

These changes adjust table formatting width, swap a test suite script entrypoint from run_grpo_math.py to run_grpo.py, and disable a moonlight test pending fixes.

Changes

Cohort / File(s) Summary
Test Metrics Configuration
tests/check_metrics.py
Adjusts table min_width from 150 to 220 for layout rendering.
Test Suite Updates
tests/test_suites/llm/prorlv2-qwen2.5-math-1.5b-instruct-1n8g-fsdp2tp1.sh, tests/test_suites/nightly_gb200.txt
Replaces experiment script entrypoint and disables moonlight test with explanatory comment pending fixes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Test Results For Major Changes ✅ Passed PR contains only minor changes: UI formatting adjustment, test script fix, and disabled failing test. No breaking changes, new features, or modifications affecting numerics/performance.
Title check ✅ Passed The title 'ci: Fix nightly tests' is directly related to the changeset, which includes fixes and disabling of nightly test entries. It accurately summarizes the main objective.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch kajalj/update-failing-tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable sequence diagrams in the walkthrough.

Disable the reviews.sequence_diagrams setting to disable sequence diagrams in the walkthrough.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@tests/test_suites/nightly_gb200.txt`:
- Around line 17-18: Fix the typo in the comment string "Functional moonlight
run - Disbaled till it can be fixed" by changing "Disbaled" to "Disabled" and
update the adjacent test reference comment line that mentions
"tests/test_suites/llm/grpo-moonlight-16ba3b-4n4g-megatron.sh"; additionally add
a tracking TODO comment like "# TODO(issue#<number>): re-enable
grpo-moonlight-16ba3b-4n4g-megatron.sh when fixed" so the disabled test is
tracked.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 954e3905-a822-4f1e-8293-2b429d6408ac

📥 Commits

Reviewing files that changed from the base of the PR and between 39e5415 and 7b80204.

📒 Files selected for processing (3)
  • tests/check_metrics.py
  • tests/test_suites/llm/prorlv2-qwen2.5-math-1.5b-instruct-1n8g-fsdp2tp1.sh
  • tests/test_suites/nightly_gb200.txt

Signed-off-by: Kajal Jain <kajalj@nvidia.com>
@kajalj22 kajalj22 force-pushed the kajalj/update-failing-tests branch from baf5cff to f704f4a Compare March 13, 2026 17:52
@kajalj22 kajalj22 changed the title Fix few nightly tests ci: Fix nightly tests Mar 13, 2026
@kajalj22
Copy link
Author

/ok to test

@copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 13, 2026

/ok to test

@kajalj22, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@kajalj22
Copy link
Author

/ok to test f704f4a

@kajalj22 kajalj22 added the CI:Lfast Runs a fast test suite and re-use nightly `main` container (but sync dependencies to PRs version) label Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:Lfast Runs a fast test suite and re-use nightly `main` container (but sync dependencies to PRs version)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant