[Feat] Add hashtable device API support#244
Open
rhdong wants to merge 1 commit intoNVIDIA-Merlin:masterfrom
Open
[Feat] Add hashtable device API support#244rhdong wants to merge 1 commit intoNVIDIA-Merlin:masterfrom
rhdong wants to merge 1 commit intoNVIDIA-Merlin:masterfrom
Conversation
Documentation previewhttps://nvidia-merlin.github.io/HierarchicalKV/review/pr-244 |
rhdong
force-pushed
the
hrong/tk-device-api-dev
branch
from
2d51bd1 to
cae7bab
Compare
Member
Author
|
/blossom-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds device-side read-only APIs for the hash table with a lightweight device view and tests, plus build system updates to include the new headers and test target.
Key Changes
HashTableBaseintoinclude/merlin_hashtable_base.hppand includes it frommerlin_hashtable.cuh.include/merlin_hashtable_device.cuh, includingHashTableDeviceViewand no-sync lookup helpers.kernel_utils.cuh(find_without_lock_readonly_no_sync).HashTablefor creating device views.tests/merlin_hashtable_device_api_test.cc.cufor both lookup paths.Tests
merlin_hashtable_device_api_test