Skip to content

[JOSS REVIEW] Specify linting rules in a config fileΒ #178

@Zeitsperre

Description

@Zeitsperre

In the workflows, there are linting calls that have flagged values (for flake8):

- name: Lint with flake8
  run: |
    # stop the build if there are Python syntax errors or undefined names
    flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
    # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
    flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics

It would be better to have these flake8 (or ruff) rules specified in a configuration file (flake8: .flake8/setup.cfg, ruff: pyproject.toml). The default values expected for cyclomatic complexity and line length can also be adjusted (for both projects).

Related: #121

Context: openjournals/joss-reviews#9688

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions