test: MM-1498 - Remove anti-patterns in solana-wallet-standard specs#40604
Draft
LeVinhGithub wants to merge 8 commits intomainfrom
Draft
test: MM-1498 - Remove anti-patterns in solana-wallet-standard specs#40604LeVinhGithub wants to merge 8 commits intomainfrom
LeVinhGithub wants to merge 8 commits intomainfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
✨ Files requiring CODEOWNER review ✨🧪 @MetaMask/qa (3 files, +57 -12)
|
Contributor
Builds ready [c56e63b]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
Builds ready [62da8ac]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
Builds ready [62da8ac]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
Builds ready [84de995]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
Builds ready [db60680]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
|
Contributor
Builds ready [96eb359]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The Solana Wallet Standard E2E specs had several anti-patterns that made tests flaky and harder to maintain:
driver.delay()– Arbitrary waits instead of dynamic waitsclickConfirmButton,clickCancelButton) – Brittle CSS selectors and direct driver accessChanges:
driver.delay()with dynamic waits (page objects usewaitForSelector,checkPageIsLoaded, etc.)clickConfirmButtonandclickCancelButtonfromtestHelpers.tsand replaced them withSnapSignMessageConfirmation,SnapSignTransactionConfirmation, andSnapTransactionConfirmationpage objectscheckNetworkIsDisplayed(networkName)toSnapSignMessageConfirmationandSnapTransactionConfirmationfor network assertionsBy.xpath,driver.clickElement) with page object methodsChangelog
CHANGELOG entry: null
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/MMQA-1498
Manual testing steps
yarn build:testyarn test:e2e:single "test/e2e/flask/solana-wallet-standard/**/*.spec.ts" --browser=chromeScreenshots/Recordings
N/A — code refactor only.
Pre-merge author checklist
Pre-merge reviewer checklist