fix: include yarn.lock in preview build artifacts#8023
Merged
cryptodev-2s merged 2 commits intomainfrom Feb 23, 2026
Merged
Conversation
dd221bf to
02ba12f
Compare
Member
|
This is the error in question I'm guessing? https://github.com/MetaMask/core/actions/runs/22324841398/job/64592901687 I'm not following why this change would fix this error. Is it possible that the problem is that the lockfile is not cached along with the build output? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The
publish-previewjob fails becauseyarn workspaces foreachcan't resolve the renamed@metamask-previews/packages. The root cause is thatprepare-preview-builds.shupdates the lockfile viayarn install --no-immutable, butyarn.lockis not included in the uploaded artifacts. The publish job gets a stale lockfile from main that doesn't match the renamed package names.This adds
yarn.lockto the artifact upload and removes thepathoverride on download so it extracts to the workspace root alongsidepackages/.References
Checklist
Note
Low Risk
CI workflow-only change that affects artifact packaging/restoration; low risk outside of potentially impacting preview publish reliability.
Overview
Fixes the preview publish workflow by including the updated
yarn.lockin the uploaded build artifact set, ensuring the publish job uses the same lockfile produced byyarn prepare-preview-builds.Also removes the
actions/download-artifactpathoverride so artifacts (includingyarn.lock) restore to the workspace root instead of being extracted underpackages/.Written by Cursor Bugbot for commit 0a45543. This will update automatically on new commits. Configure here.