test(approval): add tests for env fallbacks, SSL toggles, and webhook crash fix

- Discord: test DISCORD_CHANNEL_ID env fallback, SSL verify default/override
- Telegram: test TELEGRAM_CHAT_ID env fallback, SSL verify default/override
- Webhook: test integer status does not crash str().lower()

Author: MervinPraison

src/praisonai/tests/unit/test_discord_approval.py

@@ -68,6 +68,27 @@ def test_repr_masks_token(self):
         assert "super-secret-token" not in r
         assert "99" in r
 
+    def test_env_var_channel_id(self, monkeypatch):
+        monkeypatch.setenv("DISCORD_CHANNEL_ID", "env-chan-123")
+        from praisonai.bots._discord_approval import DiscordApproval
+
+        backend = DiscordApproval(token="t")
+        assert backend._channel_id == "env-chan-123"
+
+    def test_ssl_verify_default_true(self, monkeypatch):
+        monkeypatch.delenv("PRAISONAI_DISCORD_SSL_VERIFY", raising=False)
+        from praisonai.bots._discord_approval import DiscordApproval
+
+        backend = DiscordApproval(token="t", channel_id="1")
+        assert backend._ssl_verify is True
+
+    def test_ssl_verify_env_false(self, monkeypatch):
+        monkeypatch.setenv("PRAISONAI_DISCORD_SSL_VERIFY", "false")
+        from praisonai.bots._discord_approval import DiscordApproval
+
+        backend = DiscordApproval(token="t", channel_id="1")
+        assert backend._ssl_verify is False
+
 
 # ── Embed Builder ───────────────────────────────────────────────────────────
 

src/praisonai/tests/unit/test_telegram_approval.py

@@ -84,6 +84,27 @@ def test_repr_masks_token(self):
         assert "1234567890:ABCDEF" not in r
         assert "99" in r
 
+    def test_env_var_chat_id(self, monkeypatch):
+        monkeypatch.setenv("TELEGRAM_CHAT_ID", "env-chat-456")
+        from praisonai.bots._telegram_approval import TelegramApproval
+
+        backend = TelegramApproval(token="t")
+        assert backend._chat_id == "env-chat-456"
+
+    def test_ssl_verify_default_true(self, monkeypatch):
+        monkeypatch.delenv("PRAISONAI_TELEGRAM_SSL_VERIFY", raising=False)
+        from praisonai.bots._telegram_approval import TelegramApproval
+
+        backend = TelegramApproval(token="t", chat_id="1")
+        assert backend._ssl_verify is True
+
+    def test_ssl_verify_env_false(self, monkeypatch):
+        monkeypatch.setenv("PRAISONAI_TELEGRAM_SSL_VERIFY", "false")
+        from praisonai.bots._telegram_approval import TelegramApproval
+
+        backend = TelegramApproval(token="t", chat_id="1")
+        assert backend._ssl_verify is False
+
 
 # ── Message Builder ─────────────────────────────────────────────────────────
 

src/praisonai/tests/unit/test_webhook_approval.py

@@ -220,6 +220,28 @@ async def mock_http(method, url, payload=None, **kwargs):
         assert posted_payloads[0]["tool_name"] == "rm_file"
         assert "request_id" in posted_payloads[0]
 
+    def test_non_json_status_does_not_crash(self):
+        """Integer status (e.g. HTTP code) must not crash .lower()."""
+        from praisonai.bots._webhook_approval import WebhookApproval
+
+        backend = WebhookApproval(webhook_url="https://example.com", timeout=5, poll_interval=0.1)
+        poll_count = {"n": 0}
+
+        async def mock_http(method, url, payload=None, **kwargs):
+            if method == "POST":
+                return {"status": "pending"}
+            if method == "GET":
+                poll_count["n"] += 1
+                if poll_count["n"] <= 1:
+                    # Simulate non-JSON response where status is an int
+                    return {"status": 502}
+                return {"approved": True, "reason": "ok"}
+            return {}
+
+        backend._http_request = mock_http
+        decision = asyncio.run(backend.request_approval(self._make_request()))
+        assert decision.approved is True
+
 
 # ── Export / Import ─────────────────────────────────────────────────────────