Conversation
|
Thank you for raising your pull request and contributing to voscript. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
=======================================
Coverage 77.59% 77.59%
=======================================
Files 75 75
Lines 2906 2906
=======================================
Hits 2255 2255
Misses 651 651
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
💡 Codex ReviewLine 40 in e346b55 In the Docker image this service builds from ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
Pull request overview
This PR updates the dependency set used for WhisperX-based forced alignment to avoid installing yanked WhisperX 3.1.x releases, while keeping the project on the existing numpy<2 / SciPy 1.11.x baseline.
Changes:
- Bump WhisperX from
3.1.6(yanked) towhisperx==3.3.1. - Update/pin pyannote and adjacent dependencies (
pyannote.audio==3.3.2, boundedpyannote.*,pandas<3,faster-whisper==1.1.0) to stay compatible with the current numeric stack. - Document the change in both English and Chinese changelogs under Unreleased.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| doc/changelog.zh.md | Adds an Unreleased entry documenting the WhisperX/pyannote dependency move and numeric stack constraints. |
| doc/changelog.en.md | Adds the corresponding Unreleased entry in English describing the same dependency changes. |
| app/requirements.txt | Moves off yanked WhisperX 3.1.x to whisperx==3.3.1 and pins/bounds related dependencies to maintain numpy<2 / SciPy 1.11.x compatibility. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
❤️ Great PR @MapleEve ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! |
Summary
Why 3.3.1
Validation
Notes