Merge pull request #668 from grosser/grosser/frozen

agrare · agrare · commit 49dc512268c0 · 2025-10-15T15:15:36.000-04:00
[v4.y] use frozen strings
diff --git a/Gemfile b/Gemfile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 dev_gemfile = File.expand_path('Gemfile.dev.rb', __dir__)
diff --git a/Rakefile b/Rakefile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rake/testtask'
 require 'rubocop/rake_task'
diff --git a/kubeclient.gemspec b/kubeclient.gemspec
@@ -1,6 +1,6 @@
-# coding: utf-8
+# frozen_string_literal: true
 
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'kubeclient/version'
 
diff --git a/lib/kubeclient.rb b/lib/kubeclient.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 require 'rest-client'
 
diff --git a/lib/kubeclient/common.rb b/lib/kubeclient/common.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 require 'rest-client'
 
diff --git a/lib/kubeclient/config.rb b/lib/kubeclient/config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yaml'
 require 'base64'
 require 'pathname'
diff --git a/lib/kubeclient/entity_list.rb b/lib/kubeclient/entity_list.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'delegate'
 module Kubeclient
   module Common
diff --git a/lib/kubeclient/http_error.rb b/lib/kubeclient/http_error.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # TODO: remove this on next major version bump
 # Deprected http exception
 class KubeException < StandardError
@@ -12,7 +14,7 @@ def initialize(error_code, message, response)
   def to_s
     string = "HTTP status code #{@error_code}, #{@message}"
     if @response.is_a?(RestClient::Response) && @response.request
-      string << " for #{@response.request.method.upcase} #{@response.request.url}"
+      string += " for #{@response.request.method.upcase} #{@response.request.url}"
     end
     string
   end
diff --git a/lib/kubeclient/missing_kind_compatibility.rb b/lib/kubeclient/missing_kind_compatibility.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Kubeclient
   module Common
     # Backward compatibility for old versions where kind is missing (e.g. OpenShift Enterprise 3.1)
diff --git a/lib/kubeclient/resource.rb b/lib/kubeclient/resource.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'recursive_open_struct'
 
 module Kubeclient
diff --git a/lib/kubeclient/resource_not_found_error.rb b/lib/kubeclient/resource_not_found_error.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Kubeclient
   class ResourceNotFoundError < HttpError
   end
diff --git a/lib/kubeclient/watch_stream.rb b/lib/kubeclient/watch_stream.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 require 'http'
 module Kubeclient
@@ -21,7 +23,7 @@ def each
           raise Kubeclient::HttpError.new(response.code, response.reason, response)
         end
 
-        buffer = ''
+        buffer = +''
         response.body.each do |chunk|
           buffer << chunk
           while (line = buffer.slice!(/.+\n/))
diff --git a/test/test_common.rb b/test/test_common.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 require_relative 'test_helper'
 
diff --git a/test/test_common_url_handling.rb b/test/test_common_url_handling.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 
 # URLHandling tests
diff --git a/test/test_component_status.rb b/test/test_component_status.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 
 # ComponentStatus tests
diff --git a/test/test_config.rb b/test/test_config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 require 'yaml'
 require 'open3'
diff --git a/test/test_endpoint.rb b/test/test_endpoint.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 
 # kind: 'Endpoints' entity tests.
diff --git a/test/test_exec_credentials.rb b/test/test_exec_credentials.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 require 'open3'
 
diff --git a/test/test_gcp_command_credentials.rb b/test/test_gcp_command_credentials.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 require 'open3'
 
diff --git a/test/test_google_application_default_credentials.rb b/test/test_google_application_default_credentials.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 require 'googleauth'
 
diff --git a/test/test_guestbook_go.rb b/test/test_guestbook_go.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 require 'vcr'
 
diff --git a/test/test_helper.rb b/test/test_helper.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/setup'
 require 'minitest/autorun'
 require 'minitest/rg'
diff --git a/test/test_kubeclient.rb b/test/test_kubeclient.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 
 # Kubernetes client entity tests
diff --git a/test/test_limit_range.rb b/test/test_limit_range.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 
 # LimitRange tests
diff --git a/test/test_missing_methods.rb b/test/test_missing_methods.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 
 # Test method_missing, respond_to? and respond_to_missing behaviour
diff --git a/test/test_namespace.rb b/test/test_namespace.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 
 # Namespace entity tests
diff --git a/test/test_node.rb b/test/test_node.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 
 # Node entity tests
diff --git a/test/test_oidc_auth_provider.rb b/test/test_oidc_auth_provider.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 require 'openid_connect'
 
diff --git a/test/test_persistent_volume.rb b/test/test_persistent_volume.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 
 # PersistentVolume tests
diff --git a/test/test_persistent_volume_claim.rb b/test/test_persistent_volume_claim.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 
 # PersistentVolumeClaim tests
diff --git a/test/test_pod.rb b/test/test_pod.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 
 # Pod entity tests
diff --git a/test/test_pod_log.rb b/test/test_pod_log.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 
 # Pod log tests
diff --git a/test/test_process_template.rb b/test/test_process_template.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 
 # Process Template tests
diff --git a/test/test_replication_controller.rb b/test/test_replication_controller.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 
 # Replication Controller entity tests
diff --git a/test/test_resource_list_without_kind.rb b/test/test_resource_list_without_kind.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 
 # Core api resource list without kind tests
diff --git a/test/test_resource_quota.rb b/test/test_resource_quota.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 
 # ResourceQuota tests
diff --git a/test/test_secret.rb b/test/test_secret.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 
 # Namespace entity tests
diff --git a/test/test_security_context_constraint.rb b/test/test_security_context_constraint.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 
 # kind: 'SecurityContextConstraints' entity tests.
diff --git a/test/test_service.rb b/test/test_service.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 
 # Service entity tests
diff --git a/test/test_service_account.rb b/test/test_service_account.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 
 # ServiceAccount tests
diff --git a/test/test_watch.rb b/test/test_watch.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'test_helper'
 
 # Watch entity tests

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`source 'https://rubygems.org'`
`2`	`4`
`3`	`5`	`dev_gemfile = File.expand_path('Gemfile.dev.rb', __dir__)`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require 'bundler/gem_tasks'`
`2`	`4`	`require 'rake/testtask'`
`3`	`5`	`require 'rubocop/rake_task'`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require 'json'`
`2`	`4`	`require 'rest-client'`
`3`	`5`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require 'yaml'`
`2`	`4`	`require 'base64'`
`3`	`5`	`require 'pathname'`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require 'delegate'`
`2`	`4`	`module Kubeclient`
`3`	`5`	`module Common`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require 'recursive_open_struct'`
`2`	`4`
`3`	`5`	`module Kubeclient`