bugfix: Fixed and tested all structured components and issues with Empty packets sent by some servers

bugfix: Fixed and tested all structured components and issues with Empty packets sent by some servers

Author: milutinke

.skills/mcc-integration-testing/SKILL.md

@@ -115,7 +115,31 @@ Use this for TPS, movement-cadence, or packet-cadence work:
 
 Run them against a real server with a temp config and summarize counts from the captured logs.
 
-### 4. Full inventory regression sweep
+### 4. Structured components test
+
+Use this after touching any `StructuredComponents` code (registries, component
+parsers, subcomponents, codec helpers) to prove every component type in a
+version parses on the wire without error:
+
+```bash
+bash tools/run-structured-components-test.sh 1.21.11
+```
+
+Run a single version (fast, ~2 min) or a matrix:
+
+```bash
+for v in 1.20.6 1.21 1.21.2 1.21.5 1.21.11 26.1; do
+  bash tools/run-structured-components-test.sh "$v"
+done
+```
+
+The script gives items with every registered component via RCON `/give`, reads
+them back with `inventory player list`, and asserts no parse errors in the MCC
+log. Version-gated components (v1212+, v1215+, v12111+, v261) are tested only
+on the versions that support them. See `SC_Integration_Test_Report.md` for a
+reference run across all 6 version groups.
+
+### 5. Full inventory regression sweep
 
 Use this when touching inventory snapshots, player/container slot sync, creative inventory, item-slot serialization, packet palettes, game-mode updates, or block-use paths that open containers:
 
@@ -198,6 +222,8 @@ Optionally override the login name with the fourth argument to the config helper
   - ordered creative-mode E2E regression scenario
 - `tools/run-inventory-full-sweep.sh`
   - full inventory command/API sweep across one or more versions
+- `tools/run-structured-components-test.sh`
+  - exercises every structured component via RCON `/give` across versions 1.20.6-26.1
 
 ## Evidence Discipline
 

AGENTS.md

@@ -123,3 +123,4 @@ Read `docs/guide/ai-assisted-development.md` before starting development work on
 - Don't trust older docs over current code for supported versions or feature gates. When AGENTS.md, skills, and older docs disagree, prefer current code and current tool behavior, then update the stale source.
 - Don't hardcode user-facing strings (messages, labels, help text) directly in source code; always use `Translations.*` resources so the text can be localized.
 - Never use "—" ("em dash"), unless specifically being instructed to do so!
+- Never generate MCC config files (`.ini`) in the repo root. When `dotnet run --project MinecraftClient -- --help` is used to generate a config template, it writes `MinecraftClient.ini` to the current directory. Always run this command from a system temp directory (e.g. `mktemp -d`) or use `prepare_offline_mcc_config.sh` which already handles output routing.

MinecraftClient/Inventory/BookContent.cs

@@ -100,7 +100,7 @@ private static bool TryReadWritable(Item item, out BookContent content)
     {
         if (item.Components is not null)
         {
-            var component = item.Components.OfType<WritableBlookContentComponent>().FirstOrDefault();
+            var component = item.Components.OfType<WritableBookContentComponent>().FirstOrDefault();
             if (component is not null)
             {
                 content = new BookContent(
@@ -121,7 +121,7 @@ private static bool TryReadWritten(Item item, out BookContent content)
     {
         if (item.Components is not null)
         {
-            var component = item.Components.OfType<WrittenBlookContentComponent>().FirstOrDefault();
+            var component = item.Components.OfType<WrittenBookContentComponent>().FirstOrDefault();
             if (component is not null)
             {
                 content = new BookContent(

MinecraftClient/Protocol/Handlers/Protocol18.cs

@@ -362,7 +362,10 @@ internal void PacketReader(object? o)
                 {
                     while (socketWrapper.HasDataAvailable())
                     {
-                        packetQueue.Add(ReadNextPacket(), cancelToken);
+                        var packet = ReadNextPacket();
+                        if (packet.Item1 == -1)
+                            continue;
+                        packetQueue.Add(packet, cancelToken);
 
                         if (cancelToken.IsCancellationRequested)
                             break;
@@ -418,7 +421,8 @@ internal void PacketReader(object? o)
         internal Tuple<int, Queue<byte>> ReadNextPacket()
         {
             var size = dataTypes.ReadNextVarIntRAW(socketWrapper); //Packet size
-            Queue<byte> packetData = new(socketWrapper.ReadDataRAW(size)); //Packet contents
+            var rawBytes = socketWrapper.ReadDataRAW(size);
+            Queue<byte> packetData = new(rawBytes); //Packet contents
             var compressed = false;
             var sizeUncompressed = 0;
 
@@ -436,6 +440,13 @@ internal Tuple<int, Queue<byte>> ReadNextPacket()
                 }
             }
 
+            if (packetData.Count == 0)
+            {
+                var rawHex = rawBytes.Length > 0 ? BitConverter.ToString(rawBytes).Replace("-", " ") : "(empty)";
+                log.Debug("Empty packet after decompress: size={0}, sizeUncompressed={1}, protocol={2}, state={3}, rawBytes=[{4}]", size, sizeUncompressed, protocolVersion, currentState, rawHex);
+                return new(-1, packetData);
+            }
+
             var packetId = dataTypes.ReadNextVarInt(packetData); // Packet ID
             LogIncomingPacket(packetId, packetData.Count, size, compressed, sizeUncompressed);
             if (handler.GetNetworkPacketCaptureEnabled())
@@ -4147,12 +4158,21 @@ private void SetCurrentState(CurrentState newState)
             log.PacketDebug(string.Format(Translations.debug_packet_state_change, previousState, newState));
         }
 
+        private static bool IsPacketExcluded(string packetType)
+        {
+            var exclusions = Settings.Config.Logging.PacketDebugExclusions;
+            return exclusions.Count > 0 && exclusions.Contains(packetType, StringComparer.OrdinalIgnoreCase);
+        }
+
         private void LogIncomingPacket(int packetId, int payloadLength, int frameLength, bool compressed, int uncompressedLength)
         {
             if (!log.DebugEnabled)
                 return;
 
             var packetType = ResolveIncomingPacketType(packetId);
+            if (IsPacketExcluded(packetType))
+                return;
+
             var compressionInfo = compression_treshold < 0
                 ? Translations.debug_packet_compression_disabled
                 : compressed
@@ -4173,10 +4193,14 @@ private void LogOutgoingPacket(int packetId, int payloadLength, string? packetTy
             if (!log.DebugEnabled)
                 return;
 
+            var resolvedType = packetType ?? ResolveOutgoingPacketType(packetId);
+            if (IsPacketExcluded(resolvedType))
+                return;
+
             log.PacketDebug(string.Format(Translations.debug_packet_outgoing,
                 currentState,
                 packetId,
-                packetType ?? ResolveOutgoingPacketType(packetId),
+                resolvedType,
                 payloadLength,
                 compression_treshold));
         }

…ponents/1_20_6/FoodComponentComponent.cs …nents/Components/1_20_6/FoodComponent.csMinecraftClient/Protocol/Handlers/StructuredComponents/Components/1_20_6/FoodComponentComponent.cs renamed to MinecraftClient/Protocol/Handlers/StructuredComponents/Components/1_20_6/FoodComponent.cs MinecraftClient/Protocol/Handlers/StructuredComponents/Components/1_20_6/FoodComponentComponent.cs renamed to MinecraftClient/Protocol/Handlers/StructuredComponents/Components/1_20_6/FoodComponent.cs

@@ -7,7 +7,7 @@
 
 namespace MinecraftClient.Protocol.Handlers.StructuredComponents.Components._1_20_6;
 
-public class FoodComponentComponent(DataTypes dataTypes, ItemPalette itemPalette, SubComponentRegistry subComponentRegistry)
+public class FoodComponent(DataTypes dataTypes, ItemPalette itemPalette, SubComponentRegistry subComponentRegistry)
     : StructuredComponent(dataTypes, itemPalette, subComponentRegistry)
 {
     public int Nutrition { get; set; }

MinecraftClient/Protocol/Handlers/StructuredComponents/Components/1_20_6/IntangibleProjectileComponent.cs

@@ -5,19 +5,6 @@
 namespace MinecraftClient.Protocol.Handlers.StructuredComponents.Components._1_20_6;
 
 public class IntangibleProjectileComponent(DataTypes dataTypes, ItemPalette itemPalette, SubComponentRegistry subComponentRegistry)
-    : StructuredComponent(dataTypes, itemPalette, subComponentRegistry)
+    : EmptyComponent(dataTypes, itemPalette, subComponentRegistry)
 {
-    public Dictionary<string, object>? Nbt { get; set; } = new();
-
-    public override void Parse(Queue<byte> data)
-    {
-        Nbt = DataTypes.ReadNextNbt(data);
-    }
-
-    public override Queue<byte> Serialize()
-    {
-        var data = new List<byte>();
-        data.AddRange(DataTypes.GetNbt(Nbt));
-        return new Queue<byte>(data);
-    }
-}
+}

…_20_6/OmniousBottleAmplifierComponent.cs …_20_6/OminousBottleAmplifierComponent.csMinecraftClient/Protocol/Handlers/StructuredComponents/Components/1_20_6/OmniousBottleAmplifierComponent.cs renamed to MinecraftClient/Protocol/Handlers/StructuredComponents/Components/1_20_6/OminousBottleAmplifierComponent.cs MinecraftClient/Protocol/Handlers/StructuredComponents/Components/1_20_6/OmniousBottleAmplifierComponent.cs renamed to MinecraftClient/Protocol/Handlers/StructuredComponents/Components/1_20_6/OminousBottleAmplifierComponent.cs

@@ -4,7 +4,7 @@
 
 namespace MinecraftClient.Protocol.Handlers.StructuredComponents.Components._1_20_6;
 
-public class OmniousBottleAmplifierComponent(DataTypes dataTypes, ItemPalette itemPalette, SubComponentRegistry subComponentRegistry)
+public class OminousBottleAmplifierComponent(DataTypes dataTypes, ItemPalette itemPalette, SubComponentRegistry subComponentRegistry)
     : StructuredComponent(dataTypes, itemPalette, subComponentRegistry)
 {
     public int Amplifier { get; set; }

MinecraftClient/Protocol/Handlers/StructuredComponents/Components/1_20_6/UnbreakableComponent.cs

@@ -4,20 +4,20 @@
 
 namespace MinecraftClient.Protocol.Handlers.StructuredComponents.Components._1_20_6;
 
-public class UnbrekableComponent1206(DataTypes dataTypes, ItemPalette itemPalette, SubComponentRegistry subComponentRegistry)
+public class UnbreakableComponent1206(DataTypes dataTypes, ItemPalette itemPalette, SubComponentRegistry subComponentRegistry)
     : StructuredComponent(dataTypes, itemPalette, subComponentRegistry)
 {
-    public bool Unbrekable { get; set; }
+    public bool Unbreakable { get; set; }
 
     public override void Parse(Queue<byte> data)
     {
-        Unbrekable = DataTypes.ReadNextBool(data);
+        Unbreakable = DataTypes.ReadNextBool(data);
     }
 
     public override Queue<byte> Serialize()
     {
         var data = new List<byte>();
-        data.AddRange(DataTypes.GetBool(Unbrekable));
+        data.AddRange(DataTypes.GetBool(Unbreakable));
         return new Queue<byte>(data);
     }
 }

…/1_20_6/WritableBlookContentComponent.cs …s/1_20_6/WritableBookContentComponent.csMinecraftClient/Protocol/Handlers/StructuredComponents/Components/1_20_6/WritableBlookContentComponent.cs renamed to MinecraftClient/Protocol/Handlers/StructuredComponents/Components/1_20_6/WritableBookContentComponent.cs MinecraftClient/Protocol/Handlers/StructuredComponents/Components/1_20_6/WritableBlookContentComponent.cs renamed to MinecraftClient/Protocol/Handlers/StructuredComponents/Components/1_20_6/WritableBookContentComponent.cs

@@ -6,7 +6,7 @@
 
 namespace MinecraftClient.Protocol.Handlers.StructuredComponents.Components._1_20_6;
 
-public class WritableBlookContentComponent(DataTypes dataTypes, ItemPalette itemPalette, SubComponentRegistry subComponentRegistry) : StructuredComponent(dataTypes, itemPalette, subComponentRegistry)
+public class WritableBookContentComponent(DataTypes dataTypes, ItemPalette itemPalette, SubComponentRegistry subComponentRegistry) : StructuredComponent(dataTypes, itemPalette, subComponentRegistry)
 {
     public List<BookPage> Pages { get; set; } = [];
 
@@ -41,7 +41,7 @@ public override Queue<byte> Serialize()
             if (page.HasFilteredContent)
             {
                 if (page.FilteredContent is null)
-                    throw new InvalidOperationException("Can not serialize WritableBlookContentComponent because page.HasFilteredContent = true, but FilteredContent is null!");
+                    throw new InvalidOperationException("Can not serialize WritableBookContentComponent because page.HasFilteredContent = true, but FilteredContent is null!");
 
                 data.AddRange(DataTypes.GetString(page.FilteredContent));
             }

…s/1_20_6/WrittenBlookContentComponent.cs …ts/1_20_6/WrittenBookContentComponent.csMinecraftClient/Protocol/Handlers/StructuredComponents/Components/1_20_6/WrittenBlookContentComponent.cs renamed to MinecraftClient/Protocol/Handlers/StructuredComponents/Components/1_20_6/WrittenBookContentComponent.cs MinecraftClient/Protocol/Handlers/StructuredComponents/Components/1_20_6/WrittenBlookContentComponent.cs renamed to MinecraftClient/Protocol/Handlers/StructuredComponents/Components/1_20_6/WrittenBookContentComponent.cs

@@ -7,7 +7,7 @@
 
 namespace MinecraftClient.Protocol.Handlers.StructuredComponents.Components._1_20_6;
 
-public class WrittenBlookContentComponent(DataTypes dataTypes, ItemPalette itemPalette, SubComponentRegistry subComponentRegistry) : StructuredComponent(dataTypes, itemPalette, subComponentRegistry)
+public class WrittenBookContentComponent(DataTypes dataTypes, ItemPalette itemPalette, SubComponentRegistry subComponentRegistry) : StructuredComponent(dataTypes, itemPalette, subComponentRegistry)
 {
     public string RawTitle { get; set; } = null!;
     public bool HasFilteredTitle { get; set; }