bugfix: Fixed crashing and bugs on 1.9, 1.9.1, 1.9.2, 1.16.2, 1.21.10 and Player Inventory

bugfix: Fixed crashing and bugs on 1.9, 1.9.1, 1.9.2, 1.16.2, 1.21.10 and Player Inventory

Author: milutinke

.skills/mcc-integration-testing/SKILL.md

@@ -115,6 +115,37 @@ Use this for TPS, movement-cadence, or packet-cadence work:
 
 Run them against a real server with a temp config and summarize counts from the captured logs.
 
+### 4. Full inventory regression sweep
+
+Use this when touching inventory snapshots, player/container slot sync, creative inventory, item-slot serialization, packet palettes, game-mode updates, or block-use paths that open containers:
+
+```bash
+tools/run-inventory-full-sweep.sh --versions "1.21.10 1.21.11"
+```
+
+Default coverage includes:
+
+- player inventory listing and inventory discovery
+- creative give/delete
+- inventory search
+- player right/left click stack split and merge
+- player drop one and drop all
+- chest open via `useblock`
+- container listing and close
+- mirrored player slots in container windows
+- shift-click and shift-right-click transfer
+- container right/left click, cursor stack, drop one, and drop all
+- creative middle-click command path
+- log scan for packet parse failures, queue-empty crashes, unhandled exceptions, and disconnects
+
+The script writes `summary.tsv` under `RUN_ROOT` and per-version logs under `/tmp/mcc-debug/inventory-full-<version>/mcc-debug.log`.
+
+When a matrix has existing PASS rows, do not rerun them unless a later code change affects that row or the user asks for a full rerun. Derive remaining rows from summaries:
+
+```bash
+awk 'FNR>1 && $2=="PASS" {print $1}' /tmp/mcc-inventory-full-sweep/*/summary.tsv | sort -V | uniq
+```
+
 ## Preconditions
 
 Before running any scenario:
@@ -165,6 +196,8 @@ Optionally override the login name with the fourth argument to the config helper
   - summarize the latest full-spectrum run
 - `tools/run-creative-e2e.sh`
   - ordered creative-mode E2E regression scenario
+- `tools/run-inventory-full-sweep.sh`
+  - full inventory command/API sweep across one or more versions
 
 ## Evidence Discipline
 
@@ -224,3 +257,7 @@ Always summarize:
 - If a test assertion fails, inspect the real MCC output before changing the code or weakening the assertion.
 - If an older server behaves oddly on Linux, check `use-native-transport=false` in `server.properties`.
 - If a matrix row fails before producing `mcc.log` or a command transcript, treat it as a harness failure, fix the environment, and rerun that row before drawing product conclusions.
+- If creative inventory commands report "You must be in Creative gamemode" after RCON switched the player, inspect game-mode update parsing before assuming creative inventory is broken. Modern servers can update local game mode through game event reason `3`.
+- If an inventory row crashes with `Queue empty` or `Failed to process incoming packet`, inspect packet palette routing before changing inventory code. A single shifted packet ID can make a healthy inventory feature look broken.
+- For chest-open failures, separate product and harness causes. The player may be standing inside the chest or suffocating on older servers. Stand beside the chest, put a floor under the player, and retry `useblock`.
+- For shared local servers, a `Done` log line does not prove RCON is ready. Retry setup commands and verify the actual RCON port from `server.properties`.

.skills/mcc-version-adaptation/SKILL.md

@@ -157,6 +157,43 @@ When packet changes are detected:
 2. Create new `PacketPaletteXXX.cs` based on the previous one, adjusting IDs
 3. Update `PacketType18Handler.cs` routing
 
+Use scriptable comparisons instead of eyeballing long packet tables. The packet ID is the registration index in `GameProtocols.java`:
+
+```bash
+python3 - <<'PY'
+import re
+for ver in ["1.21.10", "1.21.11", "26.1"]:
+    path=f"MinecraftOfficial/{ver}-decompiled/net/minecraft/network/protocol/game/GameProtocols.java"
+    text=open(path).read()
+    start=text.index("CLIENTBOUND_TEMPLATE")
+    names=[m.group(1) for m in re.finditer(r"\.addPacket\(([^,]+),", text[start:])]
+    print("==", ver, len(names))
+    for i, name in enumerate(names):
+        print(f"0x{i:02X}", name)
+PY
+```
+
+For focused diffs:
+
+```bash
+python3 - <<'PY'
+import re
+def packets(ver, marker):
+    text=open(f"MinecraftOfficial/{ver}-decompiled/net/minecraft/network/protocol/game/GameProtocols.java").read()
+    start=text.index(marker)
+    return [m.group(1) for m in re.finditer(r"\.addPacket\(([^,]+),", text[start:])]
+left, right = "1.21.10", "1.21.11"
+a, b = packets(left, "CLIENTBOUND_TEMPLATE"), packets(right, "CLIENTBOUND_TEMPLATE")
+for i in range(max(len(a), len(b))):
+    x = a[i] if i < len(a) else "<none>"
+    y = b[i] if i < len(b) else "<none>"
+    if x != y:
+        print(f"0x{i:02X}: {left}={x} | {right}={y}")
+PY
+```
+
+Do the same for `SERVERBOUND_TEMPLATE`. Clientbound and serverbound can change independently. Do not inherit a newer palette just because one side looks similar. For example, `1.21.11` used the same play packet order as `1.21.9/1.21.10` for the tested inventory path, while `26.1` had additional shifts.
+
 ## Step 5: Check Variant Encoding Changes
 
 For entity types that use variant serializers (Cat, Wolf, Frog, Painting), check if the codec changed between versions by inspecting:

MinecraftClient/Commands/Useblock.cs

@@ -1,3 +1,4 @@
+using System;
 using Brigadier.NET;
 using Brigadier.NET.Builder;
 using MinecraftClient.CommandHandler;
@@ -53,8 +54,27 @@ private int UseBlockAtLocation(CmdResult r, Location block, Hand hand)
             Location current = handler.GetCurrentLocation();
             block = block.ToAbsolute(current).ToFloor();
             Location blockCenter = block.ToCenter();
-            bool res = handler.PlaceBlock(block, Direction.Down, hand, lookAtBlock: true);
+            bool res = handler.PlaceBlock(block, GetFaceNearestPlayer(current, blockCenter), hand, lookAtBlock: true);
             return r.SetAndReturn(string.Format(Translations.cmd_useblock_use, blockCenter.X, blockCenter.Y, blockCenter.Z, res ? "succeeded" : "failed"), res);
         }
+
+        private static Direction GetFaceNearestPlayer(Location playerLocation, Location blockCenter)
+        {
+            double dx = playerLocation.X - blockCenter.X;
+            double dy = playerLocation.Y - blockCenter.Y;
+            double dz = playerLocation.Z - blockCenter.Z;
+
+            double absX = Math.Abs(dx);
+            double absY = Math.Abs(dy);
+            double absZ = Math.Abs(dz);
+
+            if (absX >= absY && absX >= absZ)
+                return dx >= 0 ? Direction.East : Direction.West;
+
+            if (absY >= absZ)
+                return dy >= 0 ? Direction.Up : Direction.Down;
+
+            return dz >= 0 ? Direction.South : Direction.North;
+        }
     }
 }

MinecraftClient/Mapping/World.cs

@@ -69,7 +69,16 @@ public class World
         /// <param name="registryCodec">Registry Codec nbt data</param>
         public static void StoreDimensionList(Dictionary<string, object> registryCodec)
         {
-            var dimensionListNbt = (object[])(((Dictionary<string, object>)registryCodec["minecraft:dimension_type"])["value"]);
+            const string namespacedDimensionTypeKey = "minecraft:dimension_type";
+            const string legacyDimensionTypeKey = "dimension_type";
+
+            if (!registryCodec.TryGetValue(namespacedDimensionTypeKey, out var dimensionTypeRegistry)
+                && !registryCodec.TryGetValue(legacyDimensionTypeKey, out dimensionTypeRegistry))
+            {
+                return;
+            }
+
+            var dimensionListNbt = (object[])(((Dictionary<string, object>)dimensionTypeRegistry)["value"]);
             foreach (var (dimensionName, dimensionType) in from Dictionary<string, object> dimensionNbt in dimensionListNbt
                                                            let dimensionName = (string)dimensionNbt["name"]
                                                            let dimensionType = (Dictionary<string, object>)dimensionNbt["element"]
@@ -333,11 +342,40 @@ public static void SetDimension(string name)
                     return; // Dimension found with prefixed name
                 }
             }
+            else
+            {
+                string unprefixedName = name["minecraft:".Length..];
+                if (dimensionList.TryGetValue(unprefixedName, out dimension))
+                {
+                    curDimension = dimension;
+                    return;
+                }
+            }
+
+            if (TryStoreDefaultVanillaDimension(name)
+                && dimensionList.TryGetValue(name, out dimension))
+            {
+                curDimension = dimension;
+                return;
+            }
 
             // If still not found, dimension does not exist
             throw new KeyNotFoundException($"Dimension '{name}' not found in dimensions dictionary.");
         }
 
+        private static bool TryStoreDefaultVanillaDimension(string name)
+        {
+            var normalizedName = name.StartsWith("minecraft:")
+                ? name
+                : "minecraft:" + name;
+
+            if (normalizedName is not ("minecraft:overworld" or "minecraft:the_nether" or "minecraft:the_end"))
+                return false;
+
+            StoreOneDimension(name, new Dictionary<string, object>());
+            return true;
+        }
+
 
 
 

MinecraftClient/McClient.cs

@@ -2022,6 +2022,90 @@ private static bool IsServerManagedOutputSlot(Container inventory, int slotId)
             };
         }
 
+        private static bool TryGetMirroredPlayerInventoryRange(Container inventory, out int firstWindowSlot, out int lastWindowSlot)
+        {
+            firstWindowSlot = -1;
+            lastWindowSlot = -1;
+
+            if (inventory.Type == ContainerType.PlayerInventory)
+                return false;
+
+            const int mirroredPlayerInventorySlotCount = 36;
+            int slotCount = inventory.Type.SlotCount();
+            if (slotCount < mirroredPlayerInventorySlotCount)
+                return false;
+
+            firstWindowSlot = slotCount - mirroredPlayerInventorySlotCount;
+            lastWindowSlot = slotCount - 1;
+            return true;
+        }
+
+        private static bool TryGetMirroredPlayerInventorySlot(Container inventory, int windowSlot, out int playerInventorySlot)
+        {
+            playerInventorySlot = -1;
+
+            if (!TryGetMirroredPlayerInventoryRange(inventory, out int firstWindowSlot, out int lastWindowSlot))
+                return false;
+
+            if (windowSlot < firstWindowSlot || windowSlot > lastWindowSlot)
+                return false;
+
+            playerInventorySlot = windowSlot - firstWindowSlot + 9;
+            return true;
+        }
+
+        private static bool AreSameInventorySlot(Item? left, Item? right)
+        {
+            if (left is null || left.IsEmpty)
+                return right is null || right.IsEmpty;
+            if (right is null || right.IsEmpty)
+                return false;
+
+            return left.Type == right.Type
+                && left.Count == right.Count
+                && left.Data == right.Data
+                && ReferenceEquals(left.NBT, right.NBT)
+                && ReferenceEquals(left.Components, right.Components);
+        }
+
+        private bool SetPlayerInventorySlot(int playerInventorySlot, Item? item)
+        {
+            if (!inventories.TryGetValue(0, out Container? playerInventory))
+                return false;
+
+            playerInventory.Items.TryGetValue(playerInventorySlot, out Item? previousItem);
+            if (AreSameInventorySlot(previousItem, item))
+                return false;
+
+            if (item is null || item.IsEmpty)
+                playerInventory.Items.Remove(playerInventorySlot);
+            else
+                playerInventory.Items[playerInventorySlot] = item;
+
+            return true;
+        }
+
+        private bool SyncPlayerInventorySlotFromWindow(Container inventory, int windowSlot)
+        {
+            if (!TryGetMirroredPlayerInventorySlot(inventory, windowSlot, out int playerInventorySlot))
+                return false;
+
+            inventory.Items.TryGetValue(windowSlot, out Item? item);
+            return SetPlayerInventorySlot(playerInventorySlot, item);
+        }
+
+        private bool SyncPlayerInventorySlotsFromWindow(Container inventory)
+        {
+            if (!TryGetMirroredPlayerInventoryRange(inventory, out int firstWindowSlot, out int lastWindowSlot))
+                return false;
+
+            bool changed = false;
+            for (int windowSlot = firstWindowSlot; windowSlot <= lastWindowSlot; windowSlot++)
+                changed |= SyncPlayerInventorySlotFromWindow(inventory, windowSlot);
+
+            return changed;
+        }
+
         /// <summary>
         /// Click a slot in the specified window
         /// </summary>
@@ -2748,6 +2832,8 @@ public bool DoWindowAction(int windowId, int slotId, WindowActionType action)
                         changedSlots.Add(new Tuple<short, Item?>((short)slotId, null));
                         break;
                 }
+
+                SyncPlayerInventorySlotsFromWindow(inventory);
             }
 
             return handler.SendWindowAction(windowId, slotId, action, item, changedSlots, inventories[windowId].StateID);
@@ -2764,7 +2850,16 @@ public bool DoWindowAction(int windowId, int slotId, WindowActionType action)
         /// <returns>TRUE if item given successfully</returns>
         public bool DoCreativeGive(int slot, ItemType itemType, int count, Dictionary<string, object>? nbt = null)
         {
-            return InvokeOnMainThread(() => handler.SendCreativeInventoryAction(slot, itemType, count, nbt));
+            return InvokeOnMainThread(() =>
+            {
+                if (!handler.SendCreativeInventoryAction(slot, itemType, count, nbt))
+                    return false;
+
+                if (slot is >= 1 and <= 45)
+                    SetPlayerInventorySlot(slot, new Item(itemType, count, nbt));
+
+                return true;
+            });
         }
 
         /// <summary>
@@ -3780,6 +3875,9 @@ public void OnWindowItems(byte inventoryID, Dictionary<int, Inventory.Item> item
             {
                 inventories[inventoryID].Items = itemList;
                 inventories[inventoryID].StateID = stateId;
+                bool playerInventoryChanged = SyncPlayerInventorySlotsFromWindow(inventories[inventoryID]);
+                if (playerInventoryChanged)
+                    DispatchBotEvent(bot => bot.OnInventoryUpdate(0));
                 DispatchBotEvent(bot => bot.OnInventoryUpdate(inventoryID));
             }
         }
@@ -3820,6 +3918,9 @@ public void OnSetSlot(byte inventoryID, short slotID, Item? item, int stateId)
                             inventories[inventoryID].Items.Remove(slotID);
                     }
                     else inventories[inventoryID].Items[slotID] = item;
+
+                    if (SyncPlayerInventorySlotFromWindow(inventories[inventoryID], slotID))
+                        DispatchBotEvent(bot => bot.OnInventoryUpdate(0));
                 }
             }
             DispatchBotEvent(bot => bot.OnInventoryUpdate(inventoryID));
@@ -4676,6 +4777,9 @@ public void OnGameEvent(byte reason, float value)
         {
             switch (reason)
             {
+                case 3:
+                    OnGamemodeUpdate(Guid.Empty, (int)value);
+                    break;
                 case 7:
                     DispatchBotEvent(bot => bot.OnRainLevelChange(value));
                     break;

MinecraftClient/MinecraftClient.csproj

@@ -59,32 +59,7 @@
     <PackageReference Include="Telegram.Bot" Version="22.9.5.3" />
   </ItemGroup>
   <ItemGroup>
-    <Compile Remove="config\ChatBots\AutoLeaveOnLowHp.cs" />
-    <Compile Remove="config\ChatBots\AutoLook.cs" />
-    <Compile Remove="config\ChatBots\AutoTree.cs" />
-    <Compile Remove="config\ChatBots\CobblestoneMiner.cs" />
-    <Compile Remove="config\ChatBots\DiscordWebhook.cs" />
-    <Compile Remove="config\ChatBots\EntityCount.cs" />
-    <Compile Remove="config\ChatBots\OreMiner.cs" />
-    <Compile Remove="config\ChatBots\PayKassa.cs" />
-    <Compile Remove="config\ChatBots\QIWIAPI.cs" />
-    <Compile Remove="config\ChatBots\SugarCaneMiner.cs" />
-    <Compile Remove="config\ChatBots\TreeFarmer.cs" />
-    <Compile Remove="config\ChatBots\VkMessager.cs" />
-    <Compile Remove="config\ChatBots\WebSocketBot.cs" />
-    <Compile Remove="config\sample-script-extended.cs" />
-    <Compile Remove="config\sample-script-packet-capture.cs" />
-    <Compile Remove="config\sample-script-pm-forwarder.cs" />
-    <Compile Remove="config\sample-script-random-command.cs" />
-    <Compile Remove="config\sample-script-tick-counter.cs" />
-    <Compile Remove="config\sample-script-with-chatbot.cs" />
-    <Compile Remove="config\sample-script-with-http-request.cs" />
-    <Compile Remove="config\sample-script-with-task.cs" />
-    <Compile Remove="config\sample-script-with-world-access.cs" />
-    <Compile Remove="config\sample-script-packet-capture.cs" />
-    <Compile Remove="config\sample-script.cs" />
-    <Compile Remove="config\ChatBots\MineCube.cs" />
-    <Compile Remove="config\ChatBots\SugarCaneFarmer.cs" />
+    <Compile Remove="config\**\*.cs" />
     <Compile Remove="Mapping\VillagerInfo.cs" />
   </ItemGroup>
   <ItemGroup>