Resolved build issue

Author: RichardAnderson

.github/workflows/release.yml

@@ -89,7 +89,7 @@ jobs:
         path: ${{ env.ASSET_NAME }}
 
   release:
-    name: Update Release
+    name: Create Release
     needs: build
     runs-on: ubuntu-latest
     steps:
@@ -123,8 +123,8 @@ jobs:
           fi
         done
 
-    - name: Update Release
-      id: update_release
+    - name: Create Release
+      id: create_release
       uses: softprops/action-gh-release@v1
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -133,13 +133,6 @@ jobs:
         name: v${{ steps.get_version.outputs.VERSION }}
         draft: false
         prerelease: false
-
-    - name: Upload Release Assets
-      uses: softprops/action-gh-release@v1
-      with:
-        tag_name: ${{ steps.get_version.outputs.TAG_NAME }}
         files: |
           ./**/*.tar.gz
-          checksums.txt
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          checksums.txt

cmd/php/add.go

@@ -7,6 +7,7 @@ import (
 	"github.com/LumoSolutions/yerd/internal/installer"
 	"github.com/LumoSolutions/yerd/internal/utils"
 	"github.com/LumoSolutions/yerd/internal/version"
+	"github.com/LumoSolutions/yerd/pkg/constants"
 	"github.com/LumoSolutions/yerd/pkg/php"
 	"github.com/spf13/cobra"
 )
@@ -48,9 +49,13 @@ func runAdd(cmd *cobra.Command, args []string) {
 
 	uncached, _ := cmd.Flags().GetBool("uncached")
 
-	fmt.Printf("Installing PHP %s...\n", phpVersion)
+	fmt.Printf("Installing PHP %s with extensions:\n", phpVersion)
+	utils.PrintExtensionsGrid(constants.DefaultPHPExtensions)
+	fmt.Println()
+	
 	if uncached {
 		fmt.Printf("ℹ️  Bypassing cache to get latest version information\n")
+		fmt.Println()
 	}
 
 	err := installer.InstallPHP(phpVersion, uncached)
@@ -63,3 +68,4 @@ func runAdd(cmd *cobra.Command, args []string) {
 
 	fmt.Printf("✓ PHP %s installed successfully\n", phpVersion)
 }
+

cmd/php/extensions.go

@@ -2,7 +2,6 @@ package php
 
 import (
 	"fmt"
-	"os"
 	"sort"
 	"strings"
 	"time"
@@ -14,7 +13,6 @@ import (
 	"github.com/LumoSolutions/yerd/pkg/extensions"
 	"github.com/LumoSolutions/yerd/pkg/php"
 	"github.com/fatih/color"
-	"github.com/olekukonko/tablewriter"
 	"github.com/spf13/cobra"
 )
 
@@ -110,7 +108,10 @@ func runAddExtensions(cmd *cobra.Command, args []string) error {
 
 	valid, invalid := extensions.ValidateExtensions(extensionsToAdd)
 	if len(invalid) > 0 {
-		color.New(color.FgRed).Printf("Invalid extensions: %s\n", strings.Join(invalid, ", "))
+		utils.PrintError("Invalid extensions:")
+		utils.PrintExtensionsGrid(invalid)
+		fmt.Println()
+
 		for _, inv := range invalid {
 			suggestions := extensions.SuggestSimilarExtensions(inv)
 			if len(suggestions) > 0 {
@@ -139,22 +140,28 @@ func runAddExtensions(cmd *cobra.Command, args []string) error {
 	}
 
 	if len(alreadyInstalled) > 0 {
-		color.New(color.FgYellow).Printf("Already installed: %s\n", strings.Join(alreadyInstalled, ", "))
+		utils.PrintWarning("Already installed:")
+		sort.Strings(alreadyInstalled)
+		utils.PrintExtensionsGrid(alreadyInstalled)
+		fmt.Println()
 	}
 
 	if len(newExtensions) == 0 {
-		color.New(color.FgYellow).Printf("No new extensions to add for PHP %s\n", phpVersion)
+		utils.PrintWarning("No new extensions to add for PHP %s", phpVersion)
 		return nil
 	}
 
+	utils.PrintInfo("Adding extensions to PHP %s:", phpVersion)
+	sort.Strings(newExtensions)
+	utils.PrintExtensionsGrid(newExtensions)
+	fmt.Println()
+
 	var finalExtensions []string
 	for ext := range currentMap {
 		finalExtensions = append(finalExtensions, ext)
 	}
 	sort.Strings(finalExtensions)
 
-	color.New(color.FgGreen).Printf("Adding extensions to PHP %s: %s\n", phpVersion, strings.Join(newExtensions, ", "))
-
 	return applyExtensionChanges(cfg, phpVersion, finalExtensions)
 }
 
@@ -201,22 +208,28 @@ func runRemoveExtensions(cmd *cobra.Command, args []string) error {
 	}
 
 	if len(notInstalled) > 0 {
-		color.New(color.FgYellow).Printf("Not installed: %s\n", strings.Join(notInstalled, ", "))
+		utils.PrintWarning("Not installed:")
+		sort.Strings(notInstalled)
+		utils.PrintExtensionsGrid(notInstalled)
+		fmt.Println()
 	}
 
 	if len(removedExtensions) == 0 {
-		color.New(color.FgYellow).Printf("No extensions to remove from PHP %s\n", phpVersion)
+		utils.PrintWarning("No extensions to remove from PHP %s", phpVersion)
 		return nil
 	}
 
+	utils.PrintInfo("Removing extensions from PHP %s:", phpVersion)
+	sort.Strings(removedExtensions)
+	utils.PrintExtensionsGrid(removedExtensions)
+	fmt.Println()
+
 	var finalExtensions []string
 	for ext := range currentMap {
 		finalExtensions = append(finalExtensions, ext)
 	}
 	sort.Strings(finalExtensions)
 
-	color.New(color.FgRed).Printf("Removing extensions from PHP %s: %s\n", phpVersion, strings.Join(removedExtensions, ", "))
-
 	return applyExtensionChanges(cfg, phpVersion, finalExtensions)
 }
 
@@ -246,7 +259,10 @@ func runReplaceExtensions(cmd *cobra.Command, args []string) error {
 
 	valid, invalid := extensions.ValidateExtensions(newExtensions)
 	if len(invalid) > 0 {
-		color.New(color.FgRed).Printf("Invalid extensions: %s\n", strings.Join(invalid, ", "))
+		utils.PrintError("Invalid extensions:")
+		utils.PrintExtensionsGrid(invalid)
+		fmt.Println()
+
 		for _, inv := range invalid {
 			suggestions := extensions.SuggestSimilarExtensions(inv)
 			if len(suggestions) > 0 {
@@ -261,66 +277,40 @@ func runReplaceExtensions(cmd *cobra.Command, args []string) error {
 	sort.Strings(currentExtensions)
 
 	if fmt.Sprintf("%v", valid) == fmt.Sprintf("%v", currentExtensions) {
-		color.New(color.FgYellow).Printf("Extensions for PHP %s are already set to: %s\n", phpVersion, strings.Join(valid, ", "))
+		utils.PrintWarning("Extensions for PHP %s are already set to:", phpVersion)
+		utils.PrintExtensionsGrid(valid)
 		return nil
 	}
 
-	color.New(color.FgCyan).Printf("Replacing all extensions for PHP %s with: %s\n", phpVersion, strings.Join(valid, ", "))
+	utils.PrintInfo("Replacing all extensions for PHP %s with:", phpVersion)
+	utils.PrintExtensionsGrid(valid)
+	fmt.Println()
 
 	return applyExtensionChanges(cfg, phpVersion, valid)
 }
 
-// listExtensions displays formatted tables of installed and available extensions for a PHP version.
+// listExtensions displays installed and available extensions in grid format for a PHP version.
 // cfg: Configuration object, version: PHP version string. Returns error if version data not found.
 func listExtensions(cfg *config.Config, version string) error {
 	installedExtensions, exists := cfg.GetPHPExtensions(version)
 	if !exists {
 		return fmt.Errorf("no extension information found for PHP %s", version)
 	}
 
-	color.New(color.FgCyan, color.Bold).Printf("PHP %s Extensions\n\n", version)
+	utils.PrintInfo("PHP %s Extensions:", version)
+	fmt.Println()
 
-	color.New(color.FgGreen, color.Bold).Println("✓ INSTALLED:")
+	utils.PrintSuccess("INSTALLED:")
 	if len(installedExtensions) == 0 {
-		color.New(color.FgYellow).Println("  No extensions installed")
+		fmt.Println("  No extensions installed")
 	} else {
-		installedTable := tablewriter.NewWriter(os.Stdout)
-		installedTable.SetHeader([]string{"Extension", "Category", "Description"})
-		installedTable.SetBorder(false)
-		installedTable.SetHeaderAlignment(tablewriter.ALIGN_LEFT)
-		installedTable.SetAlignment(tablewriter.ALIGN_LEFT)
-		installedTable.SetCenterSeparator("")
-		installedTable.SetColumnSeparator("")
-		installedTable.SetRowSeparator("")
-		installedTable.SetHeaderLine(false)
-		installedTable.SetTablePadding("  ")
-		installedTable.SetNoWhiteSpace(true)
-
 		sort.Strings(installedExtensions)
-
-		for _, extName := range installedExtensions {
-			if ext, exists := extensions.AvailableExtensions[extName]; exists {
-				installedTable.Append([]string{
-					color.New(color.FgGreen).Sprint(extName),
-					color.New(color.FgBlue).Sprint(ext.Category),
-					ext.Description,
-				})
-			} else {
-				installedTable.Append([]string{
-					color.New(color.FgRed).Sprint(extName),
-					color.New(color.FgYellow).Sprint("unknown"),
-					"Unknown extension",
-				})
-			}
-		}
-
-		installedTable.Render()
+		utils.PrintExtensionsGrid(installedExtensions)
 	}
 
 	fmt.Println()
 
-	color.New(color.FgBlue, color.Bold).Println("⊡ AVAILABLE:")
-
+	utils.PrintInfo("AVAILABLE:")
 	installedMap := make(map[string]bool)
 	for _, ext := range installedExtensions {
 		installedMap[ext] = true
@@ -334,44 +324,18 @@ func listExtensions(cfg *config.Config, version string) error {
 	}
 
 	if len(availableExtensions) == 0 {
-		color.New(color.FgYellow).Println("  All available extensions are already installed")
+		fmt.Println("  All available extensions are already installed")
 	} else {
-		availableTable := tablewriter.NewWriter(os.Stdout)
-		availableTable.SetHeader([]string{"Extension", "Category", "Description"})
-		availableTable.SetBorder(false)
-		availableTable.SetHeaderAlignment(tablewriter.ALIGN_LEFT)
-		availableTable.SetAlignment(tablewriter.ALIGN_LEFT)
-		availableTable.SetCenterSeparator("")
-		availableTable.SetColumnSeparator("")
-		availableTable.SetRowSeparator("")
-		availableTable.SetHeaderLine(false)
-		availableTable.SetTablePadding("  ")
-		availableTable.SetNoWhiteSpace(true)
-
 		sort.Strings(availableExtensions)
-
-		for _, extName := range availableExtensions {
-			ext := extensions.AvailableExtensions[extName]
-			availableTable.Append([]string{
-				color.New(color.FgWhite).Sprint(extName),
-				color.New(color.FgCyan).Sprint(ext.Category),
-				ext.Description,
-			})
-		}
-
-		availableTable.Render()
+		utils.PrintExtensionsGrid(availableExtensions)
 	}
 
 	fmt.Println()
-	color.New(color.FgMagenta, color.Bold).Println("USAGE:")
-	fmt.Printf("  %s add %s <extension>     # Add extensions\n",
-		color.New(color.FgWhite).Sprint("yerd php extensions"), version)
-	fmt.Printf("  %s remove %s <extension>  # Remove extensions\n",
-		color.New(color.FgWhite).Sprint("yerd php extensions"), version)
-	fmt.Printf("  %s replace %s <extension> # Replace all extensions\n",
-		color.New(color.FgWhite).Sprint("yerd php extensions"), version)
-	fmt.Printf("  %s %s                     # Force rebuild with current extensions\n",
-		color.New(color.FgWhite).Sprint("yerd php rebuild"), version)
+	utils.PrintInfo("USAGE:")
+	fmt.Printf("  yerd php extensions add %s <extension>     # Add extensions\n", version)
+	fmt.Printf("  yerd php extensions remove %s <extension>  # Remove extensions\n", version)
+	fmt.Printf("  yerd php extensions replace %s <extension> # Replace all extensions\n", version)
+	fmt.Printf("  yerd php rebuild %s                        # Force rebuild with current extensions\n", version)
 
 	return nil
 }
@@ -405,7 +369,7 @@ func applyExtensionChanges(cfg *config.Config, version string, extensions []stri
 
 	err := rebuildPHPWithExtensions(version, extensions)
 	done <- true
-	fmt.Print("\r")
+	fmt.Print("\r\033[K") // Clear the entire line
 
 	if err != nil {
 		color.New(color.FgRed).Printf("✗ Failed to rebuild PHP %s: %v\n", version, err)
@@ -426,7 +390,7 @@ func applyExtensionChanges(cfg *config.Config, version string, extensions []stri
 		color.New(color.FgRed).Printf("⚠️  Warning: Build succeeded but failed to save configuration: %v\n", err)
 	}
 
-	color.New(color.FgGreen).Printf("✓ Successfully updated PHP %s extensions: %s\n", version, strings.Join(extensions, ", "))
+	color.New(color.FgGreen).Printf("✓ Successfully updated PHP %s extensions\n", version)
 	return nil
 }
 

cmd/php/rebuild.go

@@ -2,7 +2,6 @@ package php
 
 import (
 	"fmt"
-	"strings"
 
 	"github.com/LumoSolutions/yerd/internal/builder"
 	"github.com/LumoSolutions/yerd/internal/config"
@@ -66,7 +65,9 @@ func runRebuild(cmd *cobra.Command, args []string) error {
 		cfg.UpdatePHPExtensions(phpVersion, currentExtensions)
 	}
 
-	utils.PrintInfo("Rebuilding PHP %s with extensions: %s", phpVersion, strings.Join(currentExtensions, ", "))
+	utils.PrintInfo("Rebuilding PHP %s with extensions:", phpVersion)
+	utils.PrintExtensionsGrid(currentExtensions)
+	fmt.Println()
 
 	if err := forceRebuildPHP(cfg, phpVersion, currentExtensions); err != nil {
 		return nil
@@ -79,6 +80,7 @@ func runRebuild(cmd *cobra.Command, args []string) error {
 // cfg: Configuration object, version: PHP version to rebuild, extensions: Extensions to include.
 func forceRebuildPHP(cfg *config.Config, version string, extensions []string) error {
 	utils.PrintWarning("Force rebuilding PHP (no configuration backup needed)...")
+	fmt.Println()
 
 	spinner := utils.NewLoadingSpinner(fmt.Sprintf("Building PHP %s with extensions", version))
 	spinner.Start()
@@ -93,20 +95,25 @@ func forceRebuildPHP(cfg *config.Config, version string, extensions []string) er
 
 	if err != nil {
 		spinner.Stop("✗ Build failed")
+		logPath := phpBuilder.GetLogPath()
 		utils.PrintError("Failed to rebuild PHP %s: %v", version, err)
+		if logPath != "" {
+			utils.PrintError("Detailed build logs available at: %s", logPath)
+		}
 		phpBuilder.Cleanup()
 		return fmt.Errorf("rebuild failed")
 	}
 
 	spinner.Stop("✓ Build complete")
 
+	utils.PrintSuccess("All dependencies satisfied")
 	utils.PrintInfo("Updating configuration...")
 	if err := cfg.Save(); err != nil {
 		utils.PrintWarning("Warning: Rebuild succeeded but failed to save configuration: %v", err)
 	}
 
 	phpBuilder.CleanupSuccess()
 
-	utils.PrintSuccess("Successfully rebuilt PHP %s with extensions: %s", version, strings.Join(extensions, ", "))
+	utils.PrintSuccess("Successfully rebuilt PHP %s", version)
 	return nil
 }