removed serialized_heap

Author: LemonHX

Cargo.lock

@@ -4,7 +4,6 @@ members = [
   "src/brimstone_icu_collections",
   "src/brimstone_macros",
   "src/js",
-  "src/brimstone_serialized_heap",
   "tests",
   "tests/fuzz",
   "tests/harness",
@@ -22,7 +21,6 @@ brimstone = { path = "src" }
 brimstone_core = { path = "src/js" }
 brimstone_icu_collections = { path = "src/brimstone_icu_collections" }
 brimstone_macros = { path = "src/brimstone_macros" }
-brimstone_serialized_heap = { path = "src/brimstone_serialized_heap" }
 
 
 # External Crates

Cargo.toml

@@ -0,0 +1,8 @@
+- [ ] no_std support
+
+- [ ] debugger
+- [ ] rust native memory allocator
+- [ ] oxc's js parser
+- [ ] crate rust's future beside js's loop
+- [ ] add promise hook
+- [ ] add compat to serde_json

TODO.md

@@ -14,7 +14,6 @@ bitflags.workspace = true
 clap = { workspace = true, features = ["derive"] }
 
 brimstone_core.workspace = true
-brimstone_serialized_heap.workspace = true
 parking_lot.workspace = true
 once_cell.workspace = true
 

src/Cargo.toml

@@ -1,11 +1,12 @@
 use std::{
+    path::Path,
     rc::Rc,
     time::{Duration, Instant},
 };
 
 use bitflags::bitflags;
 use brimstone_core::{
-    common::{options::OptionsBuilder, serialized_heap::get_default_serialized_heap},
+    common::{options::OptionsBuilder, wtf_8::Wtf8String},
     parser::{
         analyze::{analyze, AnalyzedProgramResult},
         parse_module, parse_script,
@@ -71,8 +72,16 @@ fn setup_step(file: &str, flags: TestFlags) -> (Context, ParseContext) {
         .set_options(Rc::new(options))
         .build()
         .unwrap();
-    let source = Rc::new(Source::new_from_file(&format!("benches/{file}")).unwrap());
-    let pcx = ParseContext::new(source);
+    let file = Path::new(&format!("benches/{file}"))
+        .canonicalize()
+        .unwrap();
+    let file_content_string = std::fs::read_to_string(&file).unwrap();
+    let source = Source::new_for_string(
+        file.to_str().unwrap(),
+        Wtf8String::from_string(file_content_string),
+    )
+    .unwrap();
+    let pcx = ParseContext::new(Rc::new(source));
     (cx, pcx)
 }
 
@@ -191,20 +200,14 @@ fn bench_program_all_steps(c: &mut Criterion, file: &str, flags: TestFlags) {
     );
 }
 
-fn init() {
-    brimstone_serialized_heap::init();
-}
-
 /// Benchmark context creation.
 fn context_benches(c: &mut Criterion) {
-    init();
-
     isolated_test(
         c,
         "context creation",
         || {},
         |_| {
-            let options = OptionsBuilder::new().serialized_heap(None).build();
+            let options = OptionsBuilder::new().build();
             let cx = ContextBuilder::new()
                 .set_options(Rc::new(options))
                 .build()
@@ -219,10 +222,7 @@ fn context_benches(c: &mut Criterion) {
         "context deserialization",
         || {},
         |_| {
-            let serialized_heap = get_default_serialized_heap().unwrap();
-            let options = OptionsBuilder::new()
-                .serialized_heap(Some(serialized_heap))
-                .build();
+            let options = OptionsBuilder::new().build();
             let cx = ContextBuilder::new()
                 .set_options(Rc::new(options))
                 .build()
@@ -234,8 +234,6 @@ fn context_benches(c: &mut Criterion) {
 }
 
 pub fn program_benches(c: &mut Criterion) {
-    init();
-
     bench_program_all_steps(c, "empty.js", TestFlags::empty());
     bench_program_parser(c, "fixtures/acorn.js", TestFlags::empty());
     bench_program_parser(c, "fixtures/react.js", TestFlags::empty());

src/benches/benches.rs

@@ -7,7 +7,6 @@ pub mod macros;
 pub mod math;
 pub mod memory;
 pub mod options;
-pub mod serialized_heap;
 pub mod string;
 pub mod string_iterators;
 pub mod time;

src/brimstone_serialized_heap/Cargo.toml

@@ -1,10 +1,7 @@
 use alloc::string::String;
 use parking_lot::{Mutex, MutexGuard};
 
-use super::{
-    constants::DEFAULT_HEAP_SIZE,
-    serialized_heap::{get_default_serialized_heap, SerializedHeap},
-};
+use super::constants::DEFAULT_HEAP_SIZE;
 
 /// Options passed throughout the program.
 pub struct Options {
@@ -28,9 +25,6 @@ pub struct Options {
 
     /// Whether to use colors when printing to the terminal
     pub parse_stats: bool,
-
-    /// Create the heap from this SerializedHeap if set, otherwise create heap from scratch.
-    pub serialized_heap: Option<&'static SerializedHeap<'static>>,
 }
 
 impl Options {
@@ -64,7 +58,6 @@ impl OptionsBuilder {
             dump_buffer: None,
             heap_size: DEFAULT_HEAP_SIZE,
             parse_stats: false,
-            serialized_heap: get_default_serialized_heap(),
         })
     }
 
@@ -107,12 +100,4 @@ impl OptionsBuilder {
         self.0.parse_stats = parse_stats;
         self
     }
-
-    pub fn serialized_heap(
-        mut self,
-        serialized_heap: Option<&'static SerializedHeap<'static>>,
-    ) -> Self {
-        self.0.serialized_heap = serialized_heap;
-        self
-    }
 }