Skip to content

Commit e4b583f

Browse files
authored
removes compile definition defining for spdlog target (#449)
spdlog is not build when the CMake option "KOMPUTE_OPT_USE_BUILT_IN_SPDLOG" is set to false. When activating spdlog for logging via CMake option "KOMPUTE_OPT_USE_SPDLOG", CMake will deliver an error, as the current CMake file tries to add a definition to the spdlog target. Defining the compiler definition "SPDLOG_ACTIVE_LEVEL" has no effect on spdlog itself, it just has an effect on spdlog target consumers. Therefore, it can be removed so that the project can be build with the mentioned CMake options. Signed-off-by: Matthias Möller <m_moeller@live.de>
1 parent a85321f commit e4b583f

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

src/logger/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ target_compile_definitions(kp_logger INTERFACE KOMPUTE_OPT_ACTIVE_LOG_LEVEL=KOMP
5656
if(NOT KOMPUTE_OPT_LOG_LEVEL_DISABLED)
5757
if(KOMPUTE_OPT_USE_SPDLOG)
5858
target_link_libraries(kp_logger PUBLIC spdlog::spdlog)
59-
target_compile_definitions(spdlog INTERFACE SPDLOG_ACTIVE_LEVEL=SPDLOG_LEVEL_${KOMPUTE_OPT_LOG_LEVEL})
6059
target_compile_definitions(kp_logger INTERFACE SPDLOG_ACTIVE_LEVEL=SPDLOG_LEVEL_${KOMPUTE_OPT_LOG_LEVEL})
6160
message(STATUS "setting SPDLOG_ACTIVE_LEVEL to SPDLOG_LEVEL_${KOMPUTE_OPT_LOG_LEVEL}")
6261

0 commit comments

Comments
 (0)