Merge pull request #135 from open-source-contributions/test_enhancement

Improve class namespace and assertions

Author: Kevinrob

tests/BaseTest.php

@@ -49,7 +49,7 @@ public function testNoBreakClient()
         $response = $this->client->get('anything');
 
         $this->assertEquals(200, $response->getStatusCode());
-        $this->assertEquals('Hello world!', $response->getBody());
+        $this->assertSame('Hello world!', (string)$response->getBody());
         $this->assertEquals(CacheMiddleware::HEADER_CACHE_MISS, $response->getHeaderLine(CacheMiddleware::HEADER_CACHE_INFO));
 
         $response = $this->client->get('anything');

tests/KeyValueHttpHeaderTest.php

@@ -39,7 +39,7 @@ public function testBase()
         $this->assertTrue($values->has('with-comma'));
         $this->assertTrue($values->has('yeah'));
 
-        $this->assertEquals(120, $values->get('max-age'));
+        $this->assertSame('120', $values->get('max-age'));
         $this->assertEquals(60, $values->get('stale-while-revalidate'));
         $this->assertEquals(0, $values->get('zero'));
         $this->assertEquals('', $values->get('nothing'));

tests/Strategy/GreedyCacheStrategyTest.php

@@ -1,13 +1,14 @@
 <?php
 
-namespace Kevinrob\GuzzleCache\Strategy;
+namespace Kevinrob\GuzzleCache\Tests\Strategy;
 
 use GuzzleHttp\Client;
 use GuzzleHttp\HandlerStack;
 use GuzzleHttp\Promise\FulfilledPromise;
 use GuzzleHttp\Psr7\Request;
 use GuzzleHttp\Psr7\Response;
 use Kevinrob\GuzzleCache\CacheMiddleware;
+use Kevinrob\GuzzleCache\Strategy\GreedyCacheStrategy;
 use Kevinrob\GuzzleCache\Storage\VolatileRuntimeStorage;
 use Psr\Http\Message\RequestInterface;
 use PHPUnit\Framework\TestCase;