Fix all build warnings

- Fixed SA1000: Added spaces after 'new' keyword
- Fixed SA1009: Added spaces after closing parentheses
- Fixed SA1137: Fixed indentation issues in test files
- Fixed SA1413: Added trailing commas in multi-line initializers
- Fixed SA1028: Removed trailing whitespace
- Fixed SA1201/SA1204: Fixed member ordering in PriceProjectionBuilder
- Fixed CS8618: Added default value for non-nullable PriceSize property
- Fixed S2094: Added suppression for intentionally empty AccountDetailsRequest class
- Fixed S1144: Removed unused private setters in HttpMessageHandlerSpy
- Fixed CA1305: Used CultureInfo.InvariantCulture for ToString() calls
- Fixed CA2227: Made PriceData collection property read-only
- Fixed CA2213: Implemented proper disposal of disposable fields in test classes

All 170+ build warnings have been resolved while maintaining full test coverage.

Author: KelvinVail

src/Betfair.Tests/Api/AccountDetailsTests.cs

@@ -7,7 +7,7 @@ namespace Betfair.Tests.Api;
 
 public class AccountDetailsTests : IDisposable
 {
-    private readonly HttpAdapterStub _client = new();
+    private readonly HttpAdapterStub _client = new ();
     private readonly BetfairApiClient _api;
     private bool _disposedValue;
 
@@ -48,7 +48,7 @@ public async Task ResponseShouldBeDeserializable()
             Timezone = "GMT",
             DiscountRate = 0.05,
             PointsBalance = 100,
-            CountryCode = "GB"
+            CountryCode = "GB",
         };
         _client.RespondsWithBody = expectedResponse;
 

src/Betfair.Tests/Api/AccountFundsTests.cs

@@ -1,4 +1,4 @@
-using Betfair.Api;
+using Betfair.Api;
 using Betfair.Api.Requests.Account;
 using Betfair.Api.Responses.Account;
 using Betfair.Tests.Api.TestDoubles;
@@ -7,7 +7,7 @@ namespace Betfair.Tests.Api;
 
 public class AccountFundsTests : IDisposable
 {
-    private readonly HttpAdapterStub _client = new();
+    private readonly HttpAdapterStub _client = new ();
     private readonly BetfairApiClient _api;
     private bool _disposedValue;
 
@@ -84,6 +84,7 @@ protected virtual void Dispose(bool disposing)
         {
             if (disposing)
             {
+                _client?.Dispose();
                 _api?.Dispose();
             }
 

src/Betfair.Tests/Api/AccountStatementTests.cs

@@ -8,7 +8,7 @@ namespace Betfair.Tests.Api;
 
 public class AccountStatementTests : IDisposable
 {
-    private readonly HttpAdapterStub _client = new();
+    private readonly HttpAdapterStub _client = new ();
     private readonly BetfairApiClient _api;
     private bool _disposedValue;
 

src/Betfair.Tests/Api/ApiMarketFilterTests.cs

@@ -44,7 +44,7 @@ public void TodaysCardIsDefined()
     {
         var card = new ApiMarketFilter().TodaysCard();
 
-        card.EventTypeIds.Should().Contain(EventType.HorseRacing.Id.ToString());
+        card.EventTypeIds.Should().Contain(EventType.HorseRacing.Id.ToString(System.Globalization.CultureInfo.InvariantCulture));
 
         card.MarketTypeCodes.Should().Contain(MarketType.Win.Id);
         card.MarketTypes.Should().Contain(MarketType.Win.Id);

src/Betfair.Tests/Api/ClearedOrdersTests.cs

@@ -8,7 +8,7 @@ namespace Betfair.Tests.Api;
 
 public class ClearedOrdersTests : IDisposable
 {
-    private readonly HttpAdapterStub _client = new();
+    private readonly HttpAdapterStub _client = new ();
     private readonly BetfairApiClient _api;
     private bool _disposedValue;
 

src/Betfair.Tests/Api/CompetitionsTests.cs

@@ -1,4 +1,4 @@
-using Betfair.Api;
+using Betfair.Api;
 using Betfair.Api.Requests;
 using Betfair.Api.Responses;
 using Betfair.Tests.Api.TestDoubles;

src/Betfair.Tests/Api/CurrencyRatesTests.cs

@@ -7,7 +7,7 @@ namespace Betfair.Tests.Api;
 
 public class CurrencyRatesTests : IDisposable
 {
-    private readonly HttpAdapterStub _client = new();
+    private readonly HttpAdapterStub _client = new ();
     private readonly BetfairApiClient _api;
     private bool _disposedValue;
 

src/Betfair.Tests/Api/FluentApiIntegrationTests.cs

@@ -177,7 +177,11 @@ public void Dispose()
     protected virtual void Dispose(bool disposing)
     {
         if (_disposedValue) return;
-        if (disposing) _api.Dispose();
+        if (disposing)
+        {
+            _client?.Dispose();
+            _api?.Dispose();
+        }
         _disposedValue = true;
     }
 }

src/Betfair.Tests/Api/MarketBookTests.cs

@@ -7,7 +7,7 @@ namespace Betfair.Tests.Api;
 
 public class MarketBookTests : IDisposable
 {
-    private readonly HttpAdapterStub _client = new();
+    private readonly HttpAdapterStub _client = new ();
     private readonly BetfairApiClient _api;
     private bool _disposedValue;
 

src/Betfair.Tests/Api/MarketStatusTests.cs

@@ -1,4 +1,4 @@
-using Betfair.Api;
+using Betfair.Api;
 using Betfair.Api.Responses.Markets;
 using Betfair.Tests.Api.TestDoubles;