Skip to content

Commit 9ddbb86

Browse files
CuperinoWaqar144
Cuperino
authored and
Waqar144
committed
Have ModelInspectorWidget make better use of space
By turning a few labels into lineEdits we can not only make more more efficient use of space, but we also allow people to copy information more easily. Allows GammaRay to be used on low resolution screen with high DPI. Helps solve #358
1 parent 8839044 commit 9ddbb86

File tree

2 files changed

+112
-29
lines changed

2 files changed

+112
-29
lines changed

‎plugins/modelinspector/modelinspectorwidget.cpp‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -123,12 +123,13 @@ static const MetaEnum::Value<Qt::ItemFlag> item_flag_table[] = {
123123
void ModelInspectorWidget::cellDataChanged()
124124
{
125125
const auto cellData = m_interface->currentCellData();
126-
ui->indexLabel->setText(cellData.row != -1
127-
? tr("Row: %1 Column: %2").arg(cellData.row).arg(cellData.column)
128-
: tr("Invalid"));
129-
ui->internalIdLabel->setText(cellData.internalId);
130-
ui->internalPtrLabel->setText(cellData.internalPtr);
131-
ui->flagsLabel->setText(MetaEnum::flagsToString(cellData.flags, item_flag_table));
126+
ui->indexLineEdit->setText(cellData.row != -1
127+
? tr("Row: %1 Column: %2").arg(cellData.row).arg(cellData.column)
128+
: tr("Invalid"));
129+
ui->internalIdLineEdit->setText(cellData.internalId);
130+
ui->internalPtrLineEdit->setText(cellData.internalPtr);
131+
ui->flagsPlainTextEdit->selectAll();
132+
ui->flagsPlainTextEdit->insertPlainText(MetaEnum::flagsToString(cellData.flags, item_flag_table));
132133
}
133134

134135
void ModelInspectorWidget::objectRegistered(const QString &objectName)

‎plugins/modelinspector/modelinspectorwidget.ui‎

Lines changed: 105 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@
1414
<item>
1515
<widget class="QSplitter" name="mainSplitter">
1616
<property name="orientation">
17-
<enum>Qt::Horizontal</enum>
17+
<enum>Qt::Orientation::Horizontal</enum>
1818
</property>
1919
<widget class="QSplitter" name="modelSplitter">
2020
<property name="orientation">
21-
<enum>Qt::Vertical</enum>
21+
<enum>Qt::Orientation::Vertical</enum>
2222
</property>
2323
<widget class="QWidget" name="layoutWidget_3">
2424
<layout class="QVBoxLayout" name="verticalLayout_3">
@@ -28,7 +28,7 @@
2828
<string>Models</string>
2929
</property>
3030
<property name="alignment">
31-
<set>Qt::AlignCenter</set>
31+
<set>Qt::AlignmentFlag::AlignCenter</set>
3232
</property>
3333
</widget>
3434
</item>
@@ -38,7 +38,7 @@
3838
<item>
3939
<widget class="GammaRay::DeferredTreeView" name="modelView">
4040
<property name="contextMenuPolicy">
41-
<enum>Qt::CustomContextMenu</enum>
41+
<enum>Qt::ContextMenuPolicy::CustomContextMenu</enum>
4242
</property>
4343
<property name="uniformRowHeights">
4444
<bool>true</bool>
@@ -47,22 +47,22 @@
4747
</item>
4848
</layout>
4949
</widget>
50-
<widget class="QWidget" name="">
50+
<widget class="QWidget" name="layoutWidget">
5151
<layout class="QVBoxLayout" name="verticalLayout_4">
5252
<item>
5353
<widget class="QLabel" name="label_6">
5454
<property name="text">
5555
<string>Selection Models</string>
5656
</property>
5757
<property name="alignment">
58-
<set>Qt::AlignCenter</set>
58+
<set>Qt::AlignmentFlag::AlignCenter</set>
5959
</property>
6060
</widget>
6161
</item>
6262
<item>
6363
<widget class="GammaRay::DeferredTreeView" name="selectionModelsView">
6464
<property name="contextMenuPolicy">
65-
<enum>Qt::CustomContextMenu</enum>
65+
<enum>Qt::ContextMenuPolicy::CustomContextMenu</enum>
6666
</property>
6767
<property name="rootIsDecorated">
6868
<bool>false</bool>
@@ -75,92 +75,174 @@
7575
</layout>
7676
</widget>
7777
</widget>
78-
<widget class="QWidget" name="">
78+
<widget class="QWidget" name="layoutWidget">
7979
<layout class="QVBoxLayout" name="verticalLayout_2">
8080
<item>
8181
<widget class="QLabel" name="label">
8282
<property name="text">
8383
<string>Model Content</string>
8484
</property>
8585
<property name="alignment">
86-
<set>Qt::AlignCenter</set>
86+
<set>Qt::AlignmentFlag::AlignCenter</set>
8787
</property>
8888
</widget>
8989
</item>
9090
<item>
9191
<widget class="GammaRay::DeferredTreeView" name="modelContentView">
9292
<property name="selectionBehavior">
93-
<enum>QAbstractItemView::SelectItems</enum>
93+
<enum>QAbstractItemView::SelectionBehavior::SelectItems</enum>
9494
</property>
9595
</widget>
9696
</item>
9797
</layout>
9898
</widget>
99-
<widget class="QWidget" name="">
99+
<widget class="QWidget" name="layoutWidget">
100100
<layout class="QVBoxLayout" name="verticalLayout">
101101
<item>
102102
<widget class="QLabel" name="label_2">
103103
<property name="text">
104104
<string>Cell Content</string>
105105
</property>
106106
<property name="alignment">
107-
<set>Qt::AlignCenter</set>
107+
<set>Qt::AlignmentFlag::AlignCenter</set>
108108
</property>
109109
</widget>
110110
</item>
111111
<item>
112112
<layout class="QFormLayout" name="formLayout_2">
113113
<item row="0" column="0">
114114
<widget class="QLabel" name="label_8">
115+
<property name="minimumSize">
116+
<size>
117+
<width>55</width>
118+
<height>0</height>
119+
</size>
120+
</property>
115121
<property name="text">
116-
<string>Model Index:</string>
122+
<string>Model index:</string>
123+
</property>
124+
<property name="wordWrap">
125+
<bool>true</bool>
117126
</property>
118127
</widget>
119128
</item>
120129
<item row="0" column="1">
121-
<widget class="QLabel" name="indexLabel">
130+
<widget class="QLineEdit" name="indexLineEdit">
131+
<property name="minimumSize">
132+
<size>
133+
<width>72</width>
134+
<height>0</height>
135+
</size>
136+
</property>
122137
<property name="text">
123138
<string>Invalid</string>
124139
</property>
140+
<property name="readOnly">
141+
<bool>true</bool>
142+
</property>
125143
</widget>
126144
</item>
127145
<item row="1" column="0">
128146
<widget class="QLabel" name="label_4">
147+
<property name="minimumSize">
148+
<size>
149+
<width>55</width>
150+
<height>0</height>
151+
</size>
152+
</property>
129153
<property name="text">
130-
<string>Internal Id:</string>
154+
<string>Internal id:</string>
155+
</property>
156+
<property name="wordWrap">
157+
<bool>true</bool>
131158
</property>
132159
</widget>
133160
</item>
134161
<item row="1" column="1">
135-
<widget class="QLabel" name="internalIdLabel">
136-
<property name="text">
137-
<string/>
162+
<widget class="QLineEdit" name="internalIdLineEdit">
163+
<property name="minimumSize">
164+
<size>
165+
<width>72</width>
166+
<height>0</height>
167+
</size>
168+
</property>
169+
<property name="readOnly">
170+
<bool>true</bool>
138171
</property>
139172
</widget>
140173
</item>
141174
<item row="2" column="0">
142175
<widget class="QLabel" name="label_5">
176+
<property name="minimumSize">
177+
<size>
178+
<width>55</width>
179+
<height>0</height>
180+
</size>
181+
</property>
143182
<property name="text">
144-
<string>Internal Pointer:</string>
183+
<string>Internal pointer:</string>
184+
</property>
185+
<property name="wordWrap">
186+
<bool>true</bool>
145187
</property>
146188
</widget>
147189
</item>
148190
<item row="2" column="1">
149-
<widget class="QLabel" name="internalPtrLabel">
150-
<property name="text">
151-
<string/>
191+
<widget class="QLineEdit" name="internalPtrLineEdit">
192+
<property name="minimumSize">
193+
<size>
194+
<width>72</width>
195+
<height>0</height>
196+
</size>
197+
</property>
198+
<property name="readOnly">
199+
<bool>true</bool>
152200
</property>
153201
</widget>
154202
</item>
155203
<item row="3" column="0">
156204
<widget class="QLabel" name="label_7">
205+
<property name="minimumSize">
206+
<size>
207+
<width>55</width>
208+
<height>0</height>
209+
</size>
210+
</property>
157211
<property name="text">
158212
<string>Flags:</string>
159213
</property>
160214
</widget>
161215
</item>
162216
<item row="3" column="1">
163-
<widget class="QLabel" name="flagsLabel"/>
217+
<widget class="QPlainTextEdit" name="flagsPlainTextEdit">
218+
<property name="sizePolicy">
219+
<sizepolicy hsizetype="Expanding" vsizetype="Minimum">
220+
<horstretch>0</horstretch>
221+
<verstretch>0</verstretch>
222+
</sizepolicy>
223+
</property>
224+
<property name="minimumSize">
225+
<size>
226+
<width>72</width>
227+
<height>0</height>
228+
</size>
229+
</property>
230+
<property name="acceptDrops">
231+
<bool>false</bool>
232+
</property>
233+
<property name="sizeAdjustPolicy">
234+
<enum>QAbstractScrollArea::SizeAdjustPolicy::AdjustToContents</enum>
235+
</property>
236+
<property name="undoRedoEnabled">
237+
<bool>false</bool>
238+
</property>
239+
<property name="readOnly">
240+
<bool>true</bool>
241+
</property>
242+
<property name="plainText">
243+
<string notr="true"/>
244+
</property>
245+
</widget>
164246
</item>
165247
</layout>
166248
</item>

0 commit comments

Comments
 (0)