Skip to content

Trigger CI on master#1554

Closed
DilumAluthge wants to merge 1 commit intomasterfrom
dpa/trigger-ci-1
Closed

Trigger CI on master#1554
DilumAluthge wants to merge 1 commit intomasterfrom
dpa/trigger-ci-1

Conversation

@DilumAluthge
Copy link
Member

No description provided.

@DilumAluthge
Copy link
Member Author

Yeah, looks like CI is broken on Julia nightly.

@DilumAluthge DilumAluthge marked this pull request as draft February 27, 2026 18:48
@jishnub
Copy link
Member

jishnub commented Feb 28, 2026

The error seems to arise because the convert here calls the Bidiagonal constructor

    [3] LinearAlgebra.Bidiagonal{Int64, UnitRange{Int64}}(A::LinearAlgebra.Bidiagonal{Int64, UnitRange{Int64}}, uplo::Symbol)
      @ LinearAlgebra /cache/build/tester-amdci4-10/julialang/linearalgebra-dot-jl/src/bidiag.jl:110
    [4] convert(::Type{LinearAlgebra.Bidiagonal{Int64, UnitRange{Int64}}}, A::LinearAlgebra.Bidiagonal{Int64, UnitRange{Int64}})
      @ LinearAlgebra /cache/build/tester-amdci4-10/julialang/linearalgebra-dot-jl/src/bidiag.jl:253
    [5] LinearAlgebra.Transpose{Int64, LinearAlgebra.Bidiagonal{Int64, UnitRange{Int64}}}(parent::LinearAlgebra.Bidiagonal{Int64, UnitRange{Int64}})
      @ LinearAlgebra /cache/build/tester-amdci4-10/julialang/linearalgebra-dot-jl/src/adjtrans.jl:60
    [6] LinearAlgebra.Transpose(A::LinearAlgebra.Bidiagonal{Int64, UnitRange{Int64}})
      @ LinearAlgebra /cache/build/tester-amdci4-10/julialang/linearalgebra-dot-jl/src/adjtrans.jl:65

I'm unsure why this needs to be constructed, since this is already of the correct type.

jishnub added a commit that referenced this pull request Feb 28, 2026
This follows the `convert` implementation for `AbstractArray`s and
short-circuits if the input is already of the correct type. There's no
actual construction required in this case.

Should fix the failure on master seen in
#1554
@DilumAluthge DilumAluthge deleted the dpa/trigger-ci-1 branch February 28, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants