Merge pull request #81 from JuliaGeo/claude/moc-budget-overhang

Fix budget MOC keeping giant cells on non-congruent overhang

Author: asinghvi17

docs/src/all_dggs.md

@@ -72,6 +72,7 @@ for sys in DGG.systems()
             " levels ", DGG.levels(sys),
             ", ", lpad(DGG.ncells(grid), 6), " cells at level 3",
             ", sorted subtrees: ", DGG.has_sorted_subtrees(sys),
+            ", congruent refinement: ", DGG.has_congruent_refinement(sys),
             ", id: ", nameof(DGG.cellindextype(sys)))
 end
 ```

docs/src/api/boundaries.md

@@ -122,6 +122,7 @@ globalindex
 descendant_range
 descendants
 has_sorted_subtrees
+has_congruent_refinement
 has_direct_location
 node_extent
 maxneighbors

lib/DiscreteGlobalGridsConformanceTesting/src/DiscreteGlobalGridsConformanceTesting.jl

@@ -1417,6 +1417,8 @@ DGG.node_extent(w::GenericFallbackSystem, c::AbstractCellIndex) =
     DGG.node_extent(w.system, c)
 DGG.cap_inflation(w::GenericFallbackSystem) = DGG.cap_inflation(w.system)
 DGG.has_sorted_subtrees(w::GenericFallbackSystem) = DGG.has_sorted_subtrees(w.system)
+DGG.has_congruent_refinement(w::GenericFallbackSystem) =
+    DGG.has_congruent_refinement(w.system)
 DGG.descendant_range(w::GenericFallbackSystem, c::AbstractCellIndex, l::Integer) =
     DGG.descendant_range(w.system, c, l)
 DGG.maxneighbors(w::GenericFallbackSystem, conn::Connectivity) =

src/DiscreteGlobalGrids.jl

@@ -283,6 +283,10 @@ Important cross-system traits:
     [`cap_inflation`](@ref) to `1.75`.
   - **[`has_sorted_subtrees`](@ref).** True except for A5, whose canonical order
     has not established the two-sided [`descendant_range`](@ref) contract.
+  - **[`has_congruent_refinement`](@ref).** True for HEALPix, S2 and ISEA4R,
+    whose four children tile their parent exactly; false for IGeo7, H3 and A5.
+    A `maxcells` [`MultiOrderCellSet`](@ref) descends through meeting cells
+    alone where it holds, and through cells that miss as well where it does not.
   - **[`has_direct_location`](@ref).** True for every system here: each names
     the cell containing a point from the point's coordinates, so a
     [`PartialGrid`](@ref) over any of them locates through its complete level
@@ -396,7 +400,7 @@ export cellsize, levelfor
 # the hierarchy's parent is a method on Base's function, not a name to re-export.
 export cellindextype, levels, maxlevel, levelgrid, rootcells, children
 export node_extent, maxneighbors, maxring, winding, has_sorted_subtrees
-export has_direct_location
+export has_congruent_refinement, has_direct_location
 export ancestor, descendants, descendant_range
 export subtree
 export cellid

src/engine/engine.jl

@@ -27,7 +27,7 @@ import ..DiscreteGlobalGrids: AbstractGrid, AbstractHierarchicalGridSystem,
     cellindextype, levels, maxlevel, levelgrid, rootcells, children,
     node_extent, cap_inflation, maxneighbors, maxring, winding,
     static_capacity, STATIC_RING_CAP, STATIC_RING_BYTES,
-    has_sorted_subtrees, has_direct_location,
+    has_sorted_subtrees, has_congruent_refinement, has_direct_location,
     ancestor, descendants, descendant_range,
     subtree,
     border_engine, interior_engine, halo_engine,
@@ -77,6 +77,8 @@ include("extent_memo.jl")
 include("tiled_raster.jl")
 include("query.jl")
 include("multiorder.jl")
+include("multiorder_budget.jl")
+include("multiorder_set.jl")
 include("cell_vector.jl")
 # The stencil layer reads every collection above it — the subset grid, the
 # compressed vector, the multi-order set — and the lazy border walkers besides.