update menu.current before calling menu.keypress#18
Open
matthias314 wants to merge 2 commits intoJuliaCollections:masterfrom
Open
update menu.current before calling menu.keypress#18matthias314 wants to merge 2 commits intoJuliaCollections:masterfrom
menu.current before calling menu.keypress#18matthias314 wants to merge 2 commits intoJuliaCollections:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 156 153 -3
=========================================
- Hits 156 153 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
I've added a second commit that likewise updates |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it makes sense that
menu.currentpoints to the current menu item when the user-definedkeypressfunction is called for aTreeMenu. Currently this is not the case unless the key is space. In this case the current menu item is needed to process the key press correctly, and user-definedkeypressfunctions will often be in the same situation.