allow general IO argument in writeline#17
Open
matthias314 wants to merge 1 commit intoJuliaCollections:masterfrom
Open
allow general IO argument in writeline#17matthias314 wants to merge 1 commit intoJuliaCollections:masterfrom
IO argument in writeline#17matthias314 wants to merge 1 commit intoJuliaCollections:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 156 152 -4
=========================================
- Hits 156 152 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method for
TerminalMenus.writelinedefined in this package assumes its first argument to be of typeIOBuffer. The documentation, however, only guaranteesIO. CurrentlyIOBufferis used, but I guess there a good chance that this changes toAnnotatedIOBufferifTerminalMenusdecides to support colors viaStyledStrings. So it's probably better to stay on the safe side.